add ra4, gI, gA drag tables and sources where available#8
Merged
deicon merged 7 commits intodeicon:developfrom Sep 8, 2025
Merged
Conversation
Owner
|
I appreciate the effort you put into this here :) I just ported this lib last year during my vacation and obviously missed some important pieces :) |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR expands the drag model system by adding support for three new ballistic drag tables: gI (source: mcgi), gA (airgun pellets), and ra4 (.22 LR), along with comprehensive source documentation for traceability.
- Adds new drag table identifiers to the
DragTableIdenum with descriptive comments - Implements data tables and curve calculations for the new drag models with source URLs
- Updates the drag function factory to handle the new drag types and throws
UnimplementedErrorfor the unimplementedgCtype
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for several new drag models to the
drag.dartmodule, expanding the set of ballistic drag tables available. It introduces new drag table identifiers, provides corresponding data tables and curve calculations, and updates the drag function factory to handle these new types.Support for new drag models:
DragTableIdenum:gI(source: mcgi),gA(airgun pellets), andra4(.22 LR), along with comments for documentation.gI,gA, andra4, including source references for traceability. [1] [2] [3] [4] [5] [6] [7]dragFunctionFactoryto support the new drag tables, returning the appropriate function for each and throwing anUnimplementedErrorforgC(cylinder) as a placeholder.Documentation and traceability:
Bug fix:
gACurveis calculated fromgATableinstead ofra4Table.These changes make the drag model system more comprehensive and maintainable, allowing for more accurate ballistic calculations across a wider range of projectiles.