Conversation
0057243 to
5d5ef3e
Compare
a6e1681 to
7765eeb
Compare
|
This looks good. However, I'm assuming the implications of this change are widespread among the various Deis Workflow components. What should the (regression) testing strategy be? |
|
WRT regression testing, I think we're ok since components all have to opt-in to |
|
As far as I know, none of the other components used github.com/deis/pkg/k8s which was the only package that was changed externally (via removal), and I don't think any package outside of deis/pkg was using that one. If they were, the migration path is for users to use k8s.io/client-go/rest and k8s.io/client-go/kubernetes to instantiate their kubernetes client. No regression testing should be necessary. An org-wide search comes up with no usage of github.com/deis/pkg/k8s, and the rest of the changes have no externally-facing changes. |
|
I have a PR with similar changes to re-vendor k8s.io/kubernetes to v1.6.1, but this approach is more forward-looking. |
This PR refactors deis/pkg to use client-go and to stop relying on k8s v1.2.4 as the pinned release.