This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Make "unknown error" client errors a bit more informative#323
Merged
itowlson merged 3 commits intodeislabs:mainfrom Mar 17, 2022
Merged
Conversation
Contributor
Author
|
@thomastaylor312 do you own the GH actions for this? I am getting a failure on something to do with large regexes, but my PR does not change anything involving large regexes. |
Contributor
|
@itowlson Yeah, this is due to a new RUSTSEC vulnerability. It shouldn't effect us but running a |
thomastaylor312
approved these changes
Mar 17, 2022
Contributor
thomastaylor312
left a comment
There was a problem hiding this comment.
This is much better! Feel free to merge if you don't want to do the cargo update and I'll handle it later
radu-matei
approved these changes
Mar 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current "Unknown error" is very hard to diagnose because it depends on the server providing everything you need in the message. This is not a good thing to rely on, especially for unfortunate server devs trying to get their stuff working with the existing client, so this PR adds the following information to the "unknown error" message:
A minor change is that it will now say
Unknown error: (no error message in response)rather than a trailing colon and spaceUnknown error:. A complete message now looks likeUnknown error response: Create to http://localhost:5000/v1/_i/weather/1.2.3-ivan-20220317112555054@a4d030d845438e530f12cbf85422e82a65327443786e0c9f59fbbf282adde7e3 returned status 201 Created: (no error message in response)