Skip to content
This repository was archived by the owner on Feb 11, 2025. It is now read-only.

Comments

feat: push docker image#352

Merged
vdice merged 1 commit intodeislabs:mainfrom
FrankYang0529:add-release-docker-image
Oct 27, 2022
Merged

feat: push docker image#352
vdice merged 1 commit intodeislabs:mainfrom
FrankYang0529:add-release-docker-image

Conversation

@FrankYang0529
Copy link
Contributor

@FrankYang0529 FrankYang0529 commented Oct 26, 2022 •
edited
Loading

@FrankYang0529
Copy link
Contributor Author

FrankYang0529 commented Oct 26, 2022

@microsoft-github-policy-service agree [company="default"]

@FrankYang0529
Copy link
Contributor Author

FrankYang0529 commented Oct 26, 2022

@microsoft-github-policy-service agree

@FrankYang0529 FrankYang0529 force-pushed the add-release-docker-image branch from cd3ca71 to 136818f Compare October 26, 2022 15:24
vdice
vdice reviewed Oct 26, 2022
View reviewed changes
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defer to the code owners for final decision, but I'm wondering if we want to push to this repo's GitHub container registry instead (ghcr.io/deislabs/bindle)? We should be able to use the default $GITHUB_TOKEN to push images.

@FrankYang0529
feat: push docker image
91d119e 
Signed-off-by: Frank Yang <yangpoan@gmail.com>
@FrankYang0529 FrankYang0529 force-pushed the add-release-docker-image branch from 136818f to 91d119e Compare October 27, 2022 13:04
@FrankYang0529
Copy link
Contributor Author

FrankYang0529 commented Oct 27, 2022

Defer to the code owners for final decision, but I'm wondering if we want to push to this repo's GitHub container registry instead (ghcr.io/deislabs/bindle)? We should be able to use the default $GITHUB_TOKEN to push images.

Yeah, I think it's good to use the default $GITHUB_TOKEN and we don't need to maintain docker credentials. Thanks. Updated it!

vdice
vdice approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@vdice vdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I appreciate how this enables forks to test/run this same workflow as well 👍

@vdice vdice merged commit 218e4f2 into deislabs:main Oct 27, 2022
@FrankYang0529 FrankYang0529 deleted the add-release-docker-image branch October 28, 2022 00:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@thomastaylor312 thomastaylor312 Awaiting requested review from thomastaylor312 thomastaylor312 is a code owner

@technosophos technosophos Awaiting requested review from technosophos technosophos is a code owner

@radu-matei radu-matei Awaiting requested review from radu-matei radu-matei is a code owner

1 more reviewer

@vdice vdice vdice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrankYang0529 @vdice