This repository was archived by the owner on Feb 11, 2025. It is now read-only.
chore(release/0.8): cherry-pick CI features/fixes#359
Merged
vdice merged 3 commits intodeislabs:release/0.8from Dec 13, 2022
Merged
chore(release/0.8): cherry-pick CI features/fixes#359vdice merged 3 commits intodeislabs:release/0.8from
vdice merged 3 commits intodeislabs:release/0.8from
Conversation
Signed-off-by: Matthew Fisher <matt.fisher@fermyon.com>
vdice
requested review from
radu-matei,
technosophos and
thomastaylor312
as code owners
thomastaylor312
approved these changes
Dec 12, 2022
Contributor
thomastaylor312
left a comment
thomastaylor312
left a comment
There was a problem hiding this comment.
Yeah, this is looking all ok to me once we can get tests passing
Contributor
|
The one failure is an easy fix. See this commit: f026e9a Probably shouldn't cherry pick it as it has lock changes as well |
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@thomastaylor312 and @bacongobbler, does the following look like the right approach towards the goal of backporting some CI improvements/fixes into a v0.8.x release (would be v0.8.2 as of writing)?
Ref #325
It incorporates both the linux-aarch64 build support and the blob-store action bump/fix. I ran the following:
edit: also added this change to pass CI: 05d7a25 ; ref #359 (comment)
If so, then I suppose we'd merge this into
release/0.8and then tag/pushv0.8.2from HEAD of this branch?