This repository was archived by the owner on Jan 27, 2021. It is now read-only.
Document global config and supported annotations #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document the chart values that affect the global configuration, and all supported annotations.
vbehar
requested review from
jeremyrickard,
krancour and
yaron2
as code owners
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 57.78% 56.98% -0.81%
==========================================
Files 11 11
Lines 623 623
==========================================
- Hits 360 355 -5
- Misses 234 239 +5
Partials 29 29
Continue to review full report at Codecov.
|
krancour
reviewed
Oct 11, 2019
krancour
reviewed
Oct 11, 2019
krancour
reviewed
Oct 11, 2019
Contributor
|
@vbehar I left a couple notes about how the sections and tables are organized and formatted, but your descriptions of each option look accurate and informative. I really appreciate this contribution. It closes a sizable gap in the docs. |
Contributor
|
@vbehar this looks spectacular. Thank you! |
vbehar
added a commit
to vbehar/osiris
that referenced
this pull request
Oct 21, 2019
* Document global config and supported annotations Document the chart values that affect the global configuration, and all supported annotations. * improve documentation
vbehar
added a commit
to dailymotion-oss/osiris
that referenced
this pull request
Sep 14, 2020
backport deislabs#42 Document the chart values that affect the global configuration, and all supported annotations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document the chart values that affect the global configuration, and all supported annotations.
Depending on which PRs got merged first between this one, and #38 or #39 I'll update the latest ones with the missing documentation.