This repository was archived by the owner on Jan 27, 2021. It is now read-only.
Fix the admission hook configuration #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because we're not mutating the deployments anymore, we shouldn't have a rule in the webhook config for it. Got the following error while trying to create a deployment: ``` $ kubectl create deployment app --image=... Error from server (InternalError): Internal error occurred: admission webhook "proxy-injector.osiris.deislabs.io" denied the request: Invalid kind for review: AdmissionReview ``` Manually editing the webhook config to remove the deployment rule fixed the issue.
vbehar
requested review from
jeremyrickard,
krancour and
yaron2
as code owners
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 58.77% 58.77%
=======================================
Files 11 11
Lines 638 638
=======================================
Hits 375 375
Misses 234 234
Partials 29 29Continue to review full report at Codecov.
|
Contributor
|
@vbehar thanks for catching this. I thought for sure I had fixed this, but apparently not. I must be recalling editing resources in my live cluster and not chart source. How embarrassing. Thanks again! |
krancour
approved these changes
Oct 28, 2019
vbehar
added a commit
to dailymotion-oss/osiris
that referenced
this pull request
Sep 14, 2020
backport deislabs#47 and deislabs#53
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because we're not mutating the deployments anymore, we shouldn't have a rule in the webhook config for it.
Got the following error while trying to create a deployment:
Manually editing the webhook config to remove the deployment rule fixed the issue.