Conversation
Restructure existing tests to use t.Run with descriptive scenario names, and add new test functions covering With*, error messages, and violation string formatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestIsandTestAsto uset.Runwith descriptive scenario names instead of index-based error messagesTestWithto verify allWith*functions preserve the parent cause in the error chainTestErrorMessageto validate the human-readable output of every error type (no violations, with violations, wrapping a cause)TestViolationStringto coverFieldViolation,QuotaViolation,PreconditionViolation, andConflictViolationstring formattingIsUnimplementedandAsUnimplementedNote
Low Risk
Low risk: changes are confined to
faults_test.goand only increase assertions around error classification, wrapping/unwrapping behavior, and message formatting.Overview
Significantly expands and restructures
faults_test.goto use namedt.Runscenarios and to cover more cases forIs*/As*helpers, including nestedfmt.Errorfwrapping, negative cases, and the previously untestedUnimplementedhelpers.Adds new tests verifying
With*wrappers preserve the original cause viaerrors.Is, validates the exactError()strings for singleton and constructed faults (including violations and wrapped causes), and coversString()formatting for all violation types.Written by Cursor Bugbot for commit d576667. This will update automatically on new commits. Configure here.