Merged
Conversation
Modified `DataHelper` to include "fileattachment" in default entities. Updated `Core.cs` with several formatting fixes and conditional compilation directives. Added new request handlers for file block uploads in `XrmMockupShared.projitems` and implemented `CommitFileBlocksUploadRequestHandler`, `InitializeFileBlocksUploadRequestHandler`, and `UploadBlockRequestHandler`.
mkholt
approved these changes
Sep 9, 2024
Member
mkholt
left a comment
mkholt
left a comment
There was a problem hiding this comment.
Looks good, as long as you don't need to actually read the data afterwards
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds boilerplate support for the three requiests
"InitializeFileBlocksUpload",
"UploadBlockRequest",
"CommitFileBlocksUploadRequest"
No file store implemented, but works for barebone testing in current customer.
Tested locally.