Refactor RenderManager with ViewportManager#1
Closed
wrvangeest wants to merge 15 commits intodelftsre:masterfrom
wrvangeest:refactor
Closed
Refactor RenderManager with ViewportManager#1wrvangeest wants to merge 15 commits intodelftsre:masterfrom wrvangeest:refactor
wrvangeest wants to merge 15 commits intodelftsre:masterfrom
wrvangeest:refactor
Conversation
Exclude /bin in each module
Tests for Camera class that covers ~70% of the code. Mock class of the Bound Interface included for one test.
Not all parts tested yet
rendersubscenenode and preloadspatial need asserts
Removed the Viewport responsibilities from RenderManager and added them to new class ViewportManager. RenderManager now has ViewportManager object, that other classes can also reach to manage the Viewports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed responsibilities for ViewPorts from RenderManager to ViewportManager. RenderManager now has a ViewportManager object that manages the viewports. Other classes can access the RM's ViewportManager to also manage them.