refactoring of jMonkeyEngine - Jaroslav Ševčík, Pawel Stępień#10
Closed
Jarda8 wants to merge 1 commit intodelftsre:masterfrom
Closed
refactoring of jMonkeyEngine - Jaroslav Ševčík, Pawel Stępień#10Jarda8 wants to merge 1 commit intodelftsre:masterfrom
Jarda8 wants to merge 1 commit intodelftsre:masterfrom
Conversation
Tests for initialize method from TextureUtil class, where SRP problem was found. Fixed SRP problem in TextureUtil class by creating new class StringBuilderForTextureUtil with static method. NativeObject class and NativeObjectManager class Unit tests before fixing. OCP shortcomming fixed ListSort gallop methods refactored + relevant tests EffectTrack dependency on ParticleEmitter broken, findEmitter() modified + relevant tests Several new interfaces created - Controllable - Writable - ISpatial, - IParticleEmitter method findEmitter in EffectTrack class refactored to use polymorphism instead of testing for class type -> method findEmitter added to Spatial, Node and ParticleEmitter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for initialize method from TextureUtil class, where SRP problem
was found. Fixed SRP problem in TextureUtil class by creating
new class StringBuilderForTextureUtil with static method.
NativeObject class and NativeObjectManager class Unit tests before
fixing.
OCP shortcomming fixed
ListSort gallop methods refactored + relevant tests
EffectTrack dependency on ParticleEmitter broken, findEmitter() modified + relevant tests
Several new interfaces created
method findEmitter in EffectTrack class refactored to use polymorphism
instead of testing for class type -> method findEmitter added to
Spatial, Node and ParticleEmitter