Skip to content

Merge conflict dealing with multiple entries for AuthorizedKeysFile#14

Merged
pzakha merged 5 commits into
delphix:masterfrom
pzakha:merge
Feb 13, 2020
Merged

Merge conflict dealing with multiple entries for AuthorizedKeysFile#14
pzakha merged 5 commits into
delphix:masterfrom
pzakha:merge

Conversation

@pzakha
Copy link
Copy Markdown
Contributor

@pzakha pzakha commented Feb 11, 2020

There's a merge conflict between #2 and canonical/cloud-init#60.

Although the PR from Canonical does fix the issue of parsing multiple AuthorizedKeysFile entries in the sshd_config file, it also introduces unwanted behaviour that copies keys from all of the files listed in AuthorizedKeysFile into the default location for the user (~/.ssh/authorized_keys). To reduce future merge conflicts, I've decided to revert my original change (see commit Revert "DLPX-61319 Cloud-init fails to add authorized user ssh key"), do the merge, then fix the unwanted behaviour (see commit cloud-init should only consider keys in first file in AuthorizedKeysFile).

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Merge with upstream

Testing

Delphix Engineering and others added 5 commits February 1, 2020 03:21
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 3.0 (quilt)
Source: cloud-init
Binary: cloud-init
Architecture: all
Version: 19.4-33-gbb4131a2-0ubuntu1~18.04.1
Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
Standards-Version: 3.9.8
Vcs-Browser: https://git.launchpad.net/cloud-init/?h=ubuntu/devel
Vcs-Git: git://git.launchpad.net/cloud-init -b ubuntu/devel
Build-Depends: debhelper (>= 9.20160709), dh-python, iproute2, pep8, po-debconf, pyflakes, python3, python3-configobj, python3-httpretty, python3-jinja2, python3-jsonpatch, python3-jsonschema, python3-mock, python3-nose, python3-oauthlib, python3-pep8, python3-pyflakes | pyflakes (<< 1.1.0-2), python3-requests, python3-serial, python3-setuptools, python3-six, python3-unittest2, python3-yaml
Package-List:
 cloud-init deb admin optional arch=all
Checksums-Sha1:
 95f006fe189161879ff52c829bd25afbab6a89cc 1083654 cloud-init_19.4-33-gbb4131a2.orig.tar.gz
 2a87d26a07d586a4f3a6abc00810e72d5ab044b1 65892 cloud-init_19.4-33-gbb4131a2-0ubuntu1~18.04.1.debian.tar.xz
Checksums-Sha256:
 1340ffcdc51a961d211c86774449e81d5814c00faac81e8448dfdf39d754995c 1083654 cloud-init_19.4-33-gbb4131a2.orig.tar.gz
 b759aa6672336a6e4748bb92932373e17cbf373ed97eb87670349600095f02c3 65892 cloud-init_19.4-33-gbb4131a2-0ubuntu1~18.04.1.debian.tar.xz
Files:
 19d52a198f032e02de9246aaa092df20 1083654 cloud-init_19.4-33-gbb4131a2.orig.tar.gz
 05b777b25c7712866c6cd1b3a9eb4b15 65892 cloud-init_19.4-33-gbb4131a2-0ubuntu1~18.04.1.debian.tar.xz
Python-Version: all

-----BEGIN PGP SIGNATURE-----

iQJNBAEBCgA3FiEE4lRR4CIbV3Pev/F47NrLFgmVrYkFAl4fXxAZHGNoYWQuc21p
dGhAY2Fub25pY2FsLmNvbQAKCRDs2ssWCZWtiYoIEACU70rHaDY+NG2UdvkdIecS
U0HtokUXuf2og+mfrZMeETGA2tUKUAGO49SPxT+GEHmFFf/e2JgRq+oSeHHYlgkT
i1RBEFTE8Xr1gJtC/+y1d81UJXEqrEoSq8baXbzs7fNDgGgGh1ScD5GAi7qzRfeQ
VbThVgpbLOVImPHOUIDDB02mjufWsJocjk3BYlXSM+S3PjRik/x+Ah8GVe9ov5jS
vbS6P9WF3aMztECuwb/jiTYSy4DYYw9G2ibfrPsZCQSuFySSShtTk2sSIbG0I3f6
rcSj/JXAkV027JT+C0nd9fqWf7nFf5rf3KpZ9mwQHz6xQ/7jRjvH04nS8xA+92Mn
ZrCkyx4K8gQZkOLnTF0nWwu16fezlNHACOYKmNLuweNsbNcq9mmqqI7c73mW+58m
CqHOZKLWtgbsoS2w3Py30Am8Ty0b11SIOHpelZ9sCFNN1azyU25UnlgEk1PMkvYF
tYDtUV8MLmzuQHblaghzK5en0zKAyoDIBYng1g4bVGB1Uv8WmHi3SHHayFQapbAt
dw1ErCnf1gpwi42biJo1WpXXBQrIjzx2kpAq5aUqIvTsYCw6GoD+PLTrtts9rKIS
Tpns5Zi3HnWAGMngCdBzIGtJ3Y24imqZDJl9z18Q4pJcd2R22dUdyXphl0Q61a+z
mtZXx4vn4M0sIHMOQvR5BA==
=ooft
-----END PGP SIGNATURE-----
@claassistantio
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pzakha
❌ Delphix Engineering


Delphix Engineering seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pzakha pzakha merged commit cde58a4 into delphix:master Feb 13, 2020
@pzakha
Copy link
Copy Markdown
Contributor Author

pzakha commented Feb 13, 2020

Fixes DLPX-68333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants