DLPX-70169 cloud-init and related services need override.conf to prevent them from running within upgrade container#15
Merged
Conversation
…ent them from running within upgrade container This is a continuation of 144e73f. As described in 144e73f, we don't want the cloud-init related services to run within an upgrade container. Unfortunately, that prior commit does not ensure the services don't run, when there's another service that depend on a cloud-init service. In our case, when running on GCP, the "google-startup-scripts" services has a depdency on "cloud-final", $ systemctl cat google-startup-scripts | grep Wants Wants=cloud-final.service causing the cloud-init service to run even though it should have otherwise been disabled (due to the changes in 144e73f). This change adds configuration to all of the cloud-init services such that they won't run in the upgrade container; even if they're inadvertently started due to a dependency, as was our case on GCP.
sebroy
approved these changes
May 28, 2020
Contributor
Author
|
|
sanbhara
approved these changes
May 28, 2020
Contributor
|
Change LGTM, does it fix the GCP upgrade issue? |
Contributor
Author
It helps, but I think there's still a lingering issue to be root caused; the "systemd-logind" service appears to fail sometimes when booting the upgrade container. So we plan to land this, and delphix/delphix-platform#224, and then continue the investigation into the "systemd-logind" service. |
pzakha
approved these changes
May 28, 2020
grwilson
pushed a commit
to grwilson/cloud-init
that referenced
this pull request
Jan 18, 2023
… to prevent them from running within upgrade container (delphix#15)" This reverts commit 61f2f79.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of 144e73f.
As described in 144e73f, we don't want the cloud-init related services
to run within an upgrade container. Unfortunately, that prior commit
does not ensure the services don't run, when there's another service
that depend on a cloud-init service. In our case, when running on GCP,
the "google-startup-scripts" services has a depdency on "cloud-final",
causing the cloud-init service to run even though it should have
otherwise been disabled (due to the changes in 144e73f).
This change adds configuration to all of the cloud-init services such
that they won't run in the upgrade container; even if they're
inadvertently started due to a dependency, as was our case on GCP.