Skip to content

DLPX-92326 Fix merge conflict after upgrading cloud-init for LTS upgrade#92

Merged
palash-gandhi merged 6 commits into
os-upgradefrom
dlpx/pr/palash-gandhi/f6a4ac32-d666-4715-a0f7-a58c83670281
Oct 10, 2024
Merged

DLPX-92326 Fix merge conflict after upgrading cloud-init for LTS upgrade#92
palash-gandhi merged 6 commits into
os-upgradefrom
dlpx/pr/palash-gandhi/f6a4ac32-d666-4715-a0f7-a58c83670281

Conversation

@palash-gandhi
Copy link
Copy Markdown
Contributor

@palash-gandhi palash-gandhi commented Oct 8, 2024

The upstreams/os-upgrade branch of this repo now contains changes from cloud-init's version on Ubuntu 24.04. When updating the os-upgrade branch via an update-package job, I discovered the following merge conflict.

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .github/workflows/cla.yml
	both modified:   cloudinit/net/__init__.py

(run3) [Tue Oct 08, 12:13:57] ~/git/cloud-init (os-upgrade)

The conflicts arose from just 1 Delphix commit - #21 which was retained. See this

Extras:

build-package job: https://ops-jenkins.eng-tools-prd.aws.delphixcloud.com/job/linux-pkg/job/os-upgrade/job/build-package/job/cloud-init/job/pre-push/9/console

Here's the diff between this PR branch and upstreams/os-upgrade: upstreams/os-upgrade...dlpx/pr/palash-gandhi/f6a4ac32-d666-4715-a0f7-a58c83670281

Here's the merge conflict:

index 3a38380,28ac814..0000000
--- a/cloudinit/net/__init__.py
+++ b/cloudinit/net/__init__.py
@@@ -565,13 -563,17 +563,27 @@@ def generate_fallback_config(config_dri
          # can't read any interfaces addresses (or there are none); give up
          return None

++<<<<<<< HEAD
 +    #
 +    # Always match on the name, rather than the MAC address. This way,
 +    # if the MAC address changes (which is possible VM environments),
 +    # the network configuration will still apply.
 +    #
 +    match = {"name": target_name}
 +
++=======
+     # netfail cannot use mac for matching, they have duplicate macs
+     if is_netfail_master(target_name):
+         match = {"name": target_name}
+     else:
+         match = {
+             "macaddress": read_sys_net_safe(target_name, "address").lower()
+         }
+     if config_driver:
+         driver = device_driver(target_name)
+         if driver:
+             match["driver"] = driver
++>>>>>>> upstreams/os-upgrade
      cfg = {
          "dhcp4": True,
          "dhcp6": True,
* Unmerged path .github/workflows/cla.yml
(run3) [Tue Oct 08, 12:14:00] ~/git/cloud-init (os-upgrade)```

Delphix Engineering and others added 3 commits September 29, 2024 04:16
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 3.0 (quilt)
Source: cloud-init
Binary: cloud-init
Architecture: all
Version: 24.3.1-0ubuntu0~20.04.1
Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
Homepage: https://cloud-init.io/
Standards-Version: 4.4.1
Vcs-Browser: https://github.com/canonical/cloud-init/tree/ubuntu/devel
Vcs-Git: https://github.com/canonical/cloud-init -b ubuntu/devel
Build-Depends: debhelper (>= 9.20160709), dh-python, iproute2, po-debconf, python3, python3-configobj, python3-debconf, python3-jinja2, python3-jsonpatch, python3-jsonschema, python3-mock, python3-oauthlib, python3-pytest, python3-pytest-mock, python3-requests, python3-serial, python3-setuptools, python3-yaml, python3-responses, python3-passlib
Package-List:
 cloud-init deb admin optional arch=all
Checksums-Sha1:
 ccd9856f874343d73c1c1b838ead0f72d1d34f7f 1824845 cloud-init_24.3.1.orig.tar.gz
 e16aed81a94feff8dd97197a41ec404e9c299e49 100912 cloud-init_24.3.1-0ubuntu0~20.04.1.debian.tar.xz
Checksums-Sha256:
 8e4946ea607440225a7a3b4651a370adef701de10494f881ab9d6bab98e3ec10 1824845 cloud-init_24.3.1.orig.tar.gz
 0204dfb57772ff558e98a4fb0ff5c70a1d857c122f1a266ab3abd7eed8e9154d 100912 cloud-init_24.3.1-0ubuntu0~20.04.1.debian.tar.xz
Files:
 86e54ae237dbf8a930efcc9a202b60ba 1824845 cloud-init_24.3.1.orig.tar.gz
 cbd4e61c4a694d17fb14ba558be6e44f 100912 cloud-init_24.3.1-0ubuntu0~20.04.1.debian.tar.xz
Python-Version: all

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE4lRR4CIbV3Pev/F47NrLFgmVrYkFAmbgb5QACgkQ7NrLFgmV
rYkEEQ//VCVq14fdTr2b89ThJeMi3bNnGHJcPnVyntRKoF/UstFMcWip79yFoCAz
ngRhmuZJuBQigetc1NK9X7AAtkFL6ywDmd9njcK5hKx2smcdF3RGRDMSO8XJPUzc
kzNhtWNqsssW7RRi51jGf4mjYsTdQutn6mvdxU2vqYRmPdudjy7xpWC8xGfnl/js
6DSf5Iuh8U74sew2SteD2MzNQxge1C2AeyNilW350UNDhP6KKwzLz6vRyKMg2p8M
HrKNyQDUi/mnUFNGAje3aDlDy3GT4ryuzT02bq28J4oABIETPqQLVcOu38fYGuXh
T6OBPK1979o2Ttttmk9X3KW0Nn4gsbso2u/98KAnsfT1qkVoX5jN05bLvJzz58yl
wiZr1pE5mojtKuB3dxUIjm2cENGaaU7uEpusKUXNc5g3Tok6iX59p6kRNMR+67iz
IHPyD/jKDiS+u+wTYuCCZWlYO07d4jJOJ1ttEGMEa7fTJGeL4gmj5dJNo1g7YGM6
Lg/x5eDbNdXbJvUNLWn59NoW88rZ8aKIiCqkwcsGRJvHmdVOc+6jC/QYFAasplVW
BN4rAWLWAPGbchBfZieSK1fKQXUFoaj5amrU8xgGQ44ktxh1EUBbqeRZMyW6jMxe
KHx+aleUDRFdGWiCZv26gFfHHXK3K80VeO0M9M4b9tWHR5qkUpE=
=E3Bw
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 3.0 (quilt)
Source: cloud-init
Binary: cloud-init
Architecture: all
Version: 24.3.1-0ubuntu0~24.04.2
Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
Homepage: https://cloud-init.io/
Standards-Version: 4.5.0
Vcs-Browser: https://github.com/canonical/cloud-init/tree/ubuntu/devel
Vcs-Git: https://github.com/canonical/cloud-init -b ubuntu/devel
Build-Depends: debhelper-compat (= 13), dh-python, iproute2, po-debconf, python3, python3-configobj, python3-debconf, python3-jinja2, python3-jsonpatch, python3-jsonschema, python3-mock, python3-oauthlib, python3-pytest, python3-pytest-mock, python3-requests, python3-serial, python3-setuptools, python3-yaml, python3-responses, python3-passlib
Package-List:
 cloud-init deb admin optional arch=all
Checksums-Sha1:
 ccd9856f874343d73c1c1b838ead0f72d1d34f7f 1824845 cloud-init_24.3.1.orig.tar.gz
 95c04dd7cd80e363b0e9e9401d2039441d3252e3 94884 cloud-init_24.3.1-0ubuntu0~24.04.2.debian.tar.xz
Checksums-Sha256:
 8e4946ea607440225a7a3b4651a370adef701de10494f881ab9d6bab98e3ec10 1824845 cloud-init_24.3.1.orig.tar.gz
 bf6d0275ea2d13556c4d5e5207867749b5e38529420c618aad32ac205a619dd1 94884 cloud-init_24.3.1-0ubuntu0~24.04.2.debian.tar.xz
Files:
 86e54ae237dbf8a930efcc9a202b60ba 1824845 cloud-init_24.3.1.orig.tar.gz
 12a04fc63bb99bb1caa8d3dbbe1b9a02 94884 cloud-init_24.3.1-0ubuntu0~24.04.2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE4lRR4CIbV3Pev/F47NrLFgmVrYkFAmbx0bsACgkQ7NrLFgmV
rYm+CxAA1FP1aMZmMXduZio43WrMhFYKAqKHSHtWafLuDddQWhim8j/bNmZW2d9B
tP2zyCGboyUS0zl8hIStNQ/p3KMv8ro6VdISsWXVyinkwzZEYH9lrzzrfpAN17DN
0crktocB4RlWP+LEnO1JAAsUUjtSIecyFizdZFvfBSrcfjALxgRjjarMiyCM6nYy
Lsz+zK5l2HPmSs7xvmNhkel+SD+qOydvdJ4pQAfnJdMl8pA3Fj4HDbT1Oo2DK+2d
sO3REVk66Z8azySRTm6Fz9/9aTYAug1B4PKjl7mGWdEmYomSuc5KWDwCxyxZWwpE
77fEce761Yygu3xU/dXCEA05k94UVDMWFgIpNyakQTzNPwEhlsNzD4VRGTyOWAfv
e+0YjUV7tCyrPZS4hGlDkiJJHpsaVJ+uYmcM90l4JHekW1UBG/znbcDP5mTN/saL
FhKBHFVFHrACA1EzzWnrH9mg3KzbJCQrk9aUWOX8DCjIuRCFushtwitzEJIrlsbF
R1ePlVZ6g84E11dLYGF4G303sGwi2Dt/E7C0RglkxwwnCe+R5Y38/XBWkQL/l8sa
zZhcgYtWlRv3QzWVOqxXLZUSQ3Me60Xj+dmmmoqLVTrffIPgNryT6TttCjOwA1JW
XIdv3cuM2/ylBBVtCTfMoOR87WcA9GDhmncNH6EMNQueeEPySJw=
=ryQh
-----END PGP SIGNATURE-----
@palash-gandhi palash-gandhi force-pushed the dlpx/pr/palash-gandhi/f6a4ac32-d666-4715-a0f7-a58c83670281 branch from 2e005d6 to 8d6bf87 Compare October 8, 2024 19:16
@palash-gandhi palash-gandhi marked this pull request as ready for review October 8, 2024 23:46
@palash-gandhi palash-gandhi merged commit d1a2dc3 into os-upgrade Oct 10, 2024
@palash-gandhi palash-gandhi deleted the dlpx/pr/palash-gandhi/f6a4ac32-d666-4715-a0f7-a58c83670281 branch October 10, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants