Skip to content

Add disclaimer and link to official upstream repository#359

Merged
prakashsurya merged 1 commit into
delphix:developfrom
sdimitro:sdimitro-patch-1
May 2, 2026
Merged

Add disclaimer and link to official upstream repository#359
prakashsurya merged 1 commit into
delphix:developfrom
sdimitro:sdimitro-patch-1

Conversation

@sdimitro
Copy link
Copy Markdown
Contributor

@sdimitro sdimitro commented May 1, 2026

Per the discussion in Slack @mmaybee @prakashsurya

Added a disclaimer about vendor-specific repository and link to official upstream.
Copy link
Copy Markdown
Contributor

@prakashsurya prakashsurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. can we go further, and archive this repo, and point to @sdimitro's?

@sdimitro
Copy link
Copy Markdown
Contributor Author

sdimitro commented May 1, 2026

@prakashsurya that's what we decided before but it's been a couple of months now and I don't want to keep bothering y'all. Besides even if this repo is archived having the pointer in the readme is good regardless. It's also a good stop-gap solution until the archival of this repo is done.

@prakashsurya
Copy link
Copy Markdown
Contributor

is there anything you're aware of in our repo, that's not in yours? I'll look into making the switch.

@prakashsurya prakashsurya merged commit 437d79e into delphix:develop May 2, 2026
5 of 17 checks passed
@sdimitro
Copy link
Copy Markdown
Contributor Author

sdimitro commented May 2, 2026

@prakashsurya you can double-check just in case but I cherry-picked the commits that you added and for each of them I cleaned it to make lint checks pass and wrote tests for them with output against the regression test crash dumps so I ensure I don't introduce regressions for you in the future.

@prakashsurya
Copy link
Copy Markdown
Contributor

@sdimitro FYI, I just landed #360 .. moving forward, we'll pull from your repo as our official upstream.. there's a note w.r.t. this in our downstream README.. it would be neat if we could add the github linkage, so this appears as a fork in the repository graph, but I don't know if that's feasible, and maybe the note in the README is sufficient..?

@sdimitro
Copy link
Copy Markdown
Contributor Author

sdimitro commented May 7, 2026

@prakashsurya - thank you so much for working on this Prakash! Yeah, looking into this, it seems like there is no way to make Github establish such a relationship after the fact (the repo existing). The README is sufficient and I really appreciate you guys working on this with me <3

@prakashsurya
Copy link
Copy Markdown
Contributor

@prakashsurya - thank you so much for working on this Prakash! Yeah, looking into this, it seems like there is no way to make Github establish such a relationship after the fact (the repo existing). The README is sufficient and I really appreciate you guys working on this with me <3

@sdimitro thank you, I still remember where the S in SDB came from 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants