Skip to content

Align BuildMark with TemplateDotNetTool template updates#100

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/check-updates-from-template
Mar 1, 2026
Merged

Align BuildMark with TemplateDotNetTool template updates#100
Malcolmnixon merged 2 commits intomainfrom
copilot/check-updates-from-template

Conversation

Copy link
Contributor

Copilot AI commented Mar 1, 2026

Pull Request

Description

Syncs BuildMark with recent TemplateDotNetTool template changes across agent docs and project configuration.

Agent Documentation (.github/agents/)

  • test-developer.md: Added Test Source Filters + MSTest V4 Best Practices sections; new Assert.StartsWith antipattern (template PR Use BuildMark-generated build notes in GitHub releases #45)
  • code-quality-agent.md: Fix markdownlint config reference → .markdownlint-cli2.jsonc
  • requirements-agent.md: Added Test Source Filters section
  • technical-writer.md: Clarified reference-style vs inline link rules; explicit exception for agent markdown files
  • software-developer.md: Fixed XML Docs rule — four-space indentation sub-rule

Project Files

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint '**/*.{yml,yaml}'

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Template PRs addressed: #41 (Polyfill package + LangVersion: latest), #45 (Assert.StartsWith antipattern), #46 (Polyfills implicit using), #44 (boolean capitalization fix).


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Update test-developer agent: add Test Source Filters and MSTest V4 Best
  Practices sections (including Assert.StartsWith antipattern from PR #45)
- Update code-quality agent: fix markdownlint reference from
  .markdownlint.json to .markdownlint-cli2.jsonc
- Update requirements agent: add Test Source Filters section
- Update technical-writer agent: clarify reference-style vs inline link rules
  including AI agent markdown files exception
- Update software-developer agent: fix XML Docs bullet with four-space indent
  sub-rule
- Update src csproj: LangVersion to latest, GenerateDocumentationFile to
  lowercase true, add package comments, update SonarAnalyzer.CSharp to
  10.20.0.135146, add Polyfill 9.12.0
- Update test csproj: LangVersion to latest, GenerateDocumentationFile to
  lowercase true, add section comments, add Polyfills implicit using,
  update Microsoft.NET.Test.Sdk to 18.3.0, update SonarAnalyzer.CSharp to
  10.20.0.135146
Copilot AI changed the title [WIP] Update application based on template changes Align BuildMark with TemplateDotNetTool template updates Mar 1, 2026
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 1, 2026 01:33
@Malcolmnixon Malcolmnixon merged commit a45a710 into main Mar 1, 2026
11 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/check-updates-from-template branch March 1, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants