Skip to content

Add Polyfills implicit using to test project#22

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/add-polyfills-to-test-csproj
Feb 28, 2026
Merged

Add Polyfills implicit using to test project#22
Malcolmnixon merged 2 commits intomainfrom
copilot/add-polyfills-to-test-csproj

Conversation

Copy link
Contributor

Copilot AI commented Feb 28, 2026

Pull Request

Description

The test project lacked an implicit using Polyfills;, preventing test code from using Polyfill extension methods without explicit using statements in each file.

Adds <Using Include="Polyfills" /> to the test csproj. No Polyfill package reference is needed — the package is already included in the main library with PrivateAssets="All", and its compiled members flow into the test project via InternalsVisibleTo.

<!-- Implicit Usings -->
<ItemGroup>
  <Using Include="Polyfills" />
</ItemGroup>

Note: adding a duplicate Polyfill package reference to the test project causes CS0121 ambiguity errors due to the types being compiled into both assemblies.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
@Malcolmnixon Malcolmnixon marked this pull request as ready for review February 28, 2026 20:54
Copilot AI changed the title [WIP] Add polyfills reference to test csproj file Add Polyfills implicit using to test project Feb 28, 2026
@Malcolmnixon Malcolmnixon merged commit 2e6b587 into main Feb 28, 2026
5 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/add-polyfills-to-test-csproj branch February 28, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants