Sync PathHelpers.SafePathCombine null validation with TemplateDotNetTool#27
Merged
Malcolmnixon merged 2 commits intomainfrom Mar 1, 2026
Merged
Conversation
…otNetTool Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review security improvements in PathHelpers.cs
Sync PathHelpers.SafePathCombine null validation with TemplateDotNetTool
Mar 1, 2026
Malcolmnixon
approved these changes
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PathHelpers.SafePathCombinewas missing theArgumentNullException.ThrowIfNullguards present in the TemplateDotNetTool reference implementation. The implementation (including all inline comments) is now identical to the template, differing only in namespace.PathHelpers.cs— Add// Validate inputsblock with null guards before the path traversal checks:PathHelpersTests.cs— AddNullBasePath_ThrowsArgumentNullExceptionandNullRelativePath_ThrowsArgumentNullExceptiontestsType of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.VersionMark --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
CodeQL scan returned 0 alerts.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.