Skip to content

Sync with TemplateDotNetTool template (PRs #39–#45)#28

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/check-template-updates
Mar 1, 2026
Merged

Sync with TemplateDotNetTool template (PRs #39–#45)#28
Malcolmnixon merged 2 commits intomainfrom
copilot/check-template-updates

Conversation

Copy link
Contributor

Copilot AI commented Mar 1, 2026

Pull Request

Description

Applies consistency updates from TemplateDotNetTool template PRs #39–#45.

GitHub Actions

  • upload-artifact v6 → v7, download-artifact v7 → v8 (build.yaml, release.yaml)
  • Add groups block for github-actions-dependencies in dependabot.yml (mirrors existing NuGet grouping)

NuGet Packages

  • SonarAnalyzer.CSharp 10.19 → 10.20 (7 false-positive fixes, S2068/S6418 promoted to Vulnerability)
  • Microsoft.NET.Test.Sdk 18.0.1 → 18.3.0
  • Add Polyfill 9.12.0 (source-only, zero runtime footprint) to main csproj

Code Quality

  • LangVersion 12latest in both csproj files
  • GenerateDocumentationFile Truetrue (boolean casing consistency)
  • Add ArgumentNullException.ThrowIfNull null guards to Context.Create(), ArgumentParser.ParseArguments(), and Validation.Run()
  • Add explanatory comments for PrivateAssets/IncludeAssets pattern in main csproj

Agent / Docs

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.VersionMark --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • Spell checker passes: cspell "**/*.{md,cs}"
  • Markdown linter passes: markdownlint "**/*.md"
  • YAML linter passes: yamllint .

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Changes are purely additive/upgrades with no behavioral impact on tool functionality. All 103 unit tests pass with 0 warnings and 0 CodeQL alerts.


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot AI changed the title [WIP] Check for updates from the template Sync with TemplateDotNetTool template (PRs #39–#45) Mar 1, 2026
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 1, 2026 01:32
@Malcolmnixon Malcolmnixon merged commit 2062941 into main Mar 1, 2026
12 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/check-template-updates branch March 1, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants