Skip to content

feat: Fruity Blood Overdrive#120

Merged
demberto merged 4 commits intodemberto:masterfrom
ttaschke:add-plugin-parser-blood-overdrive
Mar 1, 2023
Merged

feat: Fruity Blood Overdrive#120
demberto merged 4 commits intodemberto:masterfrom
ttaschke:add-plugin-parser-blood-overdrive

Conversation

@ttaschke
Copy link
Copy Markdown
Contributor

  • Adds a parser for Fruity Blood Overdrive
  • Adds .fst file for testing Fruity Blood Overdrive parse testing

Screen Shot 2023-02-25 at 19 36 39

@ttaschke
Copy link
Copy Markdown
Contributor Author

@demberto
This is a version with construct and the changes discussed in the draft PR.

I made the plugin_marker optional for now, as I was not able to get a .fst from an older plugin version. Also, I am still unsure how this would look like on a global (StructEventBase?) layer. Please let me know your thoughts on this.
https://github.com/demberto/PyFLP/pull/120/files#diff-7cbba45382f7949d6cb914fe5ee6fea2836260673dc3f868c15f2ae7ea0ce383R94

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2023

Codecov Report

Merging #120 (33ae7c0) into master (95f0742) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 33ae7c0 differs from pull request most recent head f12e0bc. Consider uploading reports for the commit f12e0bc to get more accurate results

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   87.90%   87.98%   +0.08%     
==========================================
  Files          22       22              
  Lines        3273     3296      +23     
  Branches      392      392              
==========================================
+ Hits         2877     2900      +23     
  Misses        329      329              
  Partials       67       67              
Impacted Files Coverage Δ
pyflp/mixer.py 86.07% <ø> (ø)
pyflp/plugin.py 89.62% <100.00%> (+0.42%) ⬆️
tests/test_plugin.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@demberto demberto changed the title Fruity Blood Overdrive parser feat: Fruity Blood Overdrive Feb 25, 2023
@demberto demberto self-assigned this Feb 25, 2023
@demberto demberto added the plugin-native FL Studio native generators and effects label Feb 25, 2023
@demberto demberto added this to the PyFLP 2.0.0 milestone Feb 25, 2023
@demberto demberto added the enhancement New feature or request label Feb 26, 2023
Comment thread pyflp/plugin.py Outdated
Comment thread pyflp/plugin.py
@ttaschke ttaschke force-pushed the add-plugin-parser-blood-overdrive branch from 196f263 to 1234aca Compare February 27, 2023 13:21
@demberto
Copy link
Copy Markdown
Owner

demberto commented Mar 1, 2023

Perfect :)

@demberto demberto merged commit 71bc48a into demberto:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plugin-native FL Studio native generators and effects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants