Add `TaskValidation` module by tw0po1nt · Pull Request #313 · demystifyfp/FsToolkit.ErrorHandling

tw0po1nt · 2025-03-01T18:37:08Z

Proposed Changes

Add TaskValidation module as proposed in #228

Types of changes

What types of changes does your code introduce to FsToolkit.ErrorHandling?

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Build and tests pass locally
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added necessary documentation (if appropriate)

Further comments

This will probably warrant a decent amount of scrutiny. The TaskValidation module mirrors the AsyncValidation module, along with its suite of tests, same with the ops. The code for the computation expression and its tests are derived from the TaskResult computation expression and its tests, since the AsyncValidation computation expression does not use the state machine. This should probably be fine, since Validation is simply a Result that accumulates the errors. But it may warrant some additional, Validation specific tests that I might have overlooked.

… project

tw0po1nt

self-review complete

TheAngryByrd

Lots of great work here!

I left some comments on areas I think are missing.

TheAngryByrd · 2025-03-02T20:44:54Z

+                Expect.equal actual (Validation.error errorMsg) "Should be Error"
+            }
+
+        testCaseTask "Fail Path Validation/Choice/AsyncValidation"


Unless I don't see it, I don't think there's tests covering seeing multiple failure cases. Something like how

FsToolkit.ErrorHandling/tests/FsToolkit.ErrorHandling.Tests/ValidationCE.fs

Line 448 in def0948

testCase "Fail Path Result"

is working.

Added a test covering that scenario in latest commit. Let me know if that is what you were looking for.

TheAngryByrd · 2025-03-02T20:51:01Z

+            |> Async.StartImmediateAsTask
+
+[<AutoOpen>]
+module TaskValidationCEExtensionsHighPriority2 =


I think this is missing overloads for Result<'a,'err> (where 'err is not a list). You can see examples of the overload resolution in AsyncValidation:

FsToolkit.ErrorHandling/src/FsToolkit.ErrorHandling/AsyncValidationCE.fs

Line 126 in def0948

module MediumPriority =

Added these overloads

… case

TheAngryByrd

❤️ Thank you!

@TheAngryByrd

- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd - BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261) Credits @TheAngryByrd - BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd - This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library. - BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder - BREAKING: [Rename returnError to error + documentation](#311) Credits @tw0po1nt - [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd - [Build against Net8](#251) Credits @TheAngryByrd - [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd - [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink - [feat(Seq): sequenceResultA](#255) Credits @bartelink - [Updated uses of Seq.append](#290) Credits @1eyewonder - [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt - [Add Require and Check helper methods](#295) Credits @PI-Gorbo - [Add new AsyncOption APIs and document all its other functions; minor fixes to documentation for Option module](#307) Credits @tw0po1nt - [F# 9 support and nullness](#308) Credits @TheAngryByrd - [Update IcedTasks 0.11.7](0a4cc7b) Credits @TheAngryByrd - [Add TaskValidation module](#313) Credits @tw0po1n8

@TheAngryByrd

- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd - BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261) Credits @TheAngryByrd - BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd - This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library. - BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder - BREAKING: [Rename returnError to error + documentation](#311) Credits @tw0po1nt - [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd - [Build against Net8](#251) Credits @TheAngryByrd - [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd - [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink - [feat(Seq): sequenceResultA](#255) Credits @bartelink - [Updated uses of Seq.append](#290) Credits @1eyewonder - [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt - [Add Require and Check helper methods](#295) Credits @PI-Gorbo - [Add new AsyncOption APIs and document all its other functions; minor fixes to documentation for Option module](#307) Credits @tw0po1nt - [F# 9 support and nullness](#308) Credits @TheAngryByrd - [Update IcedTasks 0.11.7](0a4cc7b) Credits @TheAngryByrd - [Add TaskValidation module](#313) Credits @tw0po1nt - [feat(Seq.traverse/sequence*)!: Yield arrays](#310) Credits @bartelink

@TheAngryByrd

- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd - BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261) Credits @TheAngryByrd - BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd - This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library. - BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder - BREAKING: [Rename returnError to error + documentation](#311) Credits @tw0po1nt - [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd - [Build against Net8](#251) Credits @TheAngryByrd - [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd - [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink - [feat(Seq): sequenceResultA](#255) Credits @bartelink - [Updated uses of Seq.append](#290) Credits @1eyewonder - [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt - [Add Require and Check helper methods](#295) Credits @PI-Gorbo - [Add new AsyncOption APIs and document all its other functions; minor fixes to documentation for Option module](#307) Credits @tw0po1nt - [F# 9 support and nullness](#308) Credits @TheAngryByrd - [Update IcedTasks 0.11.7](0a4cc7b) Credits @TheAngryByrd - [Add TaskValidation module](#313) Credits @tw0po1nt - [feat(Seq.traverse/sequence*)!: Yield arrays](#310) Credits @bartelink - [Add ParallelAsync CEs](#318) Credits @njlr

@TheAngryByrd

- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd - BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261) Credits @TheAngryByrd - BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd - This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library. - BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder - BREAKING: [Rename returnError to error + documentation](#311) Credits @tw0po1nt - [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd - [Build against Net8](#251) Credits @TheAngryByrd - [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd - [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink - [feat(Seq): sequenceResultA](#255) Credits @bartelink - [Updated uses of Seq.append](#290) Credits @1eyewonder - [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt - [Add Require and Check helper methods](#295) Credits @PI-Gorbo - [Add new AsyncOption APIs and document all its other functions; minor fixes to documentation for Option module](#307) Credits @tw0po1nt - [F# 9 support and nullness](#308) Credits @TheAngryByrd - [Update IcedTasks 0.11.7](0a4cc7b) Credits @TheAngryByrd - [Add TaskValidation module](#313) Credits @tw0po1nt - [feat(Seq.traverse/sequence*)!: Yield arrays](#310) Credits @bartelink - [Add ParallelAsync CEs](#318) Credits @njlr - [Add Option.sequenceAsyncResult and Option.traverseAsyncResult](#321) Credits @JayWearsSocks

@TheAngryByrd

- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd - BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261) Credits @TheAngryByrd - BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd - This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library. - BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder - BREAKING: [Rename returnError to error + documentation](#311) Credits @tw0po1nt - [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd - [Build against Net8](#251) Credits @TheAngryByrd - [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd - [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink - [feat(Seq): sequenceResultA](#255) Credits @bartelink - [Updated uses of Seq.append](#290) Credits @1eyewonder - [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt - [Add Require and Check helper methods](#295) Credits @PI-Gorbo - [Add new AsyncOption APIs and document all its other functions; minor fixes to documentation for Option module](#307) Credits @tw0po1nt - [F# 9 support and nullness](#308) Credits @TheAngryByrd - [Update IcedTasks 0.11.7](0a4cc7b) Credits @TheAngryByrd - [Add TaskValidation module](#313) Credits @tw0po1nt - [feat(Seq.traverse/sequence*)!: Yield arrays](#310) Credits @bartelink - [Add ParallelAsync CEs](#318) Credits @njlr - [Add Option.sequenceAsyncResult and Option.traverseAsyncResult](#321) Credits @JayWearsSocks - [Add traversals/sequences for Task and TaskResult in the Option module](#325) Credits @tw0po1nt

@TheAngryByrd

- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd - BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261) Credits @TheAngryByrd - BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd - This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library. - BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder - BREAKING: [Rename returnError to error + documentation](#311) Credits @tw0po1nt - [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd - [Build against Net8](#251) Credits @TheAngryByrd - [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd - [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink - [feat(Seq): sequenceResultA](#255) Credits @bartelink - [Updated uses of Seq.append](#290) Credits @1eyewonder - [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt - [Add Require and Check helper methods](#295) Credits @PI-Gorbo - [Add new AsyncOption APIs and document all its other functions; minor fixes to documentation for Option module](#307) Credits @tw0po1nt - [F# 9 support and nullness](#308) Credits @TheAngryByrd - [Update IcedTasks 0.11.7](0a4cc7b) Credits @TheAngryByrd - [Add TaskValidation module](#313) Credits @tw0po1nt - [feat(Seq.traverse/sequence*)!: Yield arrays](#310) Credits @bartelink - [Add ParallelAsync CEs](#318) Credits @njlr - [Add Option.sequenceAsyncResult and Option.traverseAsyncResult](#321) Credits @JayWearsSocks - [Add traversals/sequences for Task and TaskResult in the Option module](#325) Credits @tw0po1nt - [Add ok and error helper functions to TaskResultOption and AsyncResultOption modules](#327) Credits @tw0po1nt - [Add CancellableTaskOption module and CE + tests and documentation](#328) Credits @tw0po1nt

@TheAngryByrd

- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd - BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261) Credits @TheAngryByrd - BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd - This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library. - BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder - BREAKING: [Rename returnError to error + documentation](#311) Credits @tw0po1nt - [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd - [Build against Net8](#251) Credits @TheAngryByrd - [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd - [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink - [feat(Seq): sequenceResultA](#255) Credits @bartelink - [Updated uses of Seq.append](#290) Credits @1eyewonder - [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt - [Add Require and Check helper methods](#295) Credits @PI-Gorbo - [Add new AsyncOption APIs and document all its other functions; minor fixes to documentation for Option module](#307) Credits @tw0po1nt - [F# 9 support and nullness](#308) Credits @TheAngryByrd - [Update IcedTasks 0.11.7](0a4cc7b) Credits @TheAngryByrd - [Add TaskValidation module](#313) Credits @tw0po1nt - [feat(Seq.traverse/sequence*)!: Yield arrays](#310) Credits @bartelink - [Add ParallelAsync CEs](#318) Credits @njlr - [Add Option.sequenceAsyncResult and Option.traverseAsyncResult](#321) Credits @JayWearsSocks - [Add traversals/sequences for Task and TaskResult in the Option module](#325) Credits @tw0po1nt - [Add ok and error helper functions to TaskResultOption and AsyncResultOption modules](#327) Credits @tw0po1nt - [Add CancellableTaskOption module and CE + tests and documentation](#328) Credits @tw0po1nt - [Remove paket, Enforce nullness on net9.0, remove mocha](#331) Credits @TheAngryByrd - [Add TaskValueOption module, operators, and CE + tests and documentation](#329) Credits @tw0po1nt

@TheAngryByrd

- BREAKING: [Remove Ply and update to FSharp 6](#248) Credits @TheAngryByrd - BREAKING: [Remove MergeSources (and!) from some implementations like Result](#261) Credits @TheAngryByrd - BREAKING: [Merge TaskResult into Core library](#285) Credits @TheAngryByrd - This means FsToolkit.ErrorHandling.TaskResult is no longer a separate package and will not be updated. It is now part of the core library. - BREAKING: [Rename retn to singleton](#287) Credits @1eyewonder - BREAKING: [Rename returnError to error + documentation](#311) Credits @tw0po1nt - [Use Microsoft.Bcl.AsyncInterfaces in netstandard2.0 (Allows IAsyncDisposable and IAsyncEnumerable)](#250) Credits @TheAngryByrd - [Build against Net8](#251) Credits @TheAngryByrd - [Fix Overload Resolution to Align to Computation Expression used](#252) Credits @TheAngryByrd - [refactor!: Seq.sequenceResultM returns Array instead of seq](#255) Credits @bartelink - [feat(Seq): sequenceResultA](#255) Credits @bartelink - [Updated uses of Seq.append](#290) Credits @1eyewonder - [Add Option.traverseAsync and Option.sequenceAsync](#298 (comment)) Credits @tw0po1nt - [Add Require and Check helper methods](#295) Credits @PI-Gorbo - [Add new AsyncOption APIs and document all its other functions; minor fixes to documentation for Option module](#307) Credits @tw0po1nt - [F# 9 support and nullness](#308) Credits @TheAngryByrd - [Update IcedTasks 0.11.7](0a4cc7b) Credits @TheAngryByrd - [Add TaskValidation module](#313) Credits @tw0po1nt - [feat(Seq.traverse/sequence*)!: Yield arrays](#310) Credits @bartelink - [Add ParallelAsync CEs](#318) Credits @njlr - [Add Option.sequenceAsyncResult and Option.traverseAsyncResult](#321) Credits @JayWearsSocks - [Add traversals/sequences for Task and TaskResult in the Option module](#325) Credits @tw0po1nt - [Add ok and error helper functions to TaskResultOption and AsyncResultOption modules](#327) Credits @tw0po1nt - [Add CancellableTaskOption module and CE + tests and documentation](#328) Credits @tw0po1nt - [Remove paket, Enforce nullness on net9.0, remove mocha](#331) Credits @TheAngryByrd - [Add TaskValueOption module, operators, and CE + tests and documentation](#329) Credits @tw0po1nt

tw0po1nt added 5 commits February 23, 2025 20:47

Implement TaskValidation module

56daa09

Implement TaskValidationOp functions

d6ce33b

Implement TaskValidation computation expression

9bf2ed6

Add TaskValidation tests

ffa7f55

Finish TaskValidation tests; fix formatting

0d1cce0

tw0po1nt commented Mar 1, 2025

View reviewed changes

Comment thread tests/FsToolkit.ErrorHandling.Tests/FsToolkit.ErrorHandling.Tests.fsproj Outdated

tw0po1nt added 2 commits March 1, 2025 14:45

Move TaskValidation tests to FsToolkit.ErrorHandling.TaskResult.Tests…

efcab72

… project

Add gitbook documentation for TaskValidation

73fc89e

tw0po1nt commented Mar 1, 2025

View reviewed changes

TheAngryByrd requested changes Mar 2, 2025

View reviewed changes

Add overload for plain Result case; add test handling multiple errors…

ae0e031

… case

TheAngryByrd approved these changes Mar 2, 2025

View reviewed changes

TheAngryByrd merged commit 93804f4 into demystifyfp:master Mar 2, 2025

dependabot Bot mentioned this pull request May 22, 2026

Bump the dotnet-dependencies group with 16 updates agentruntimecontrolprotocol/fsharp-sdk#21

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `TaskValidation` module#313

Add `TaskValidation` module#313
TheAngryByrd merged 8 commits into
demystifyfp:masterfrom
tw0po1nt:task-validation

tw0po1nt commented Mar 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

tw0po1nt left a comment

Uh oh!

TheAngryByrd left a comment

Uh oh!

TheAngryByrd Mar 2, 2025

Uh oh!

tw0po1nt Mar 2, 2025

Uh oh!

TheAngryByrd Mar 2, 2025

Uh oh!

tw0po1nt Mar 2, 2025

Uh oh!

TheAngryByrd left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

tw0po1nt commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Changes

Types of changes

Checklist

Further comments

Uh oh!

Uh oh!

tw0po1nt left a comment

Choose a reason for hiding this comment

Uh oh!

TheAngryByrd left a comment

Choose a reason for hiding this comment

Uh oh!

TheAngryByrd Mar 2, 2025

Choose a reason for hiding this comment

Uh oh!

tw0po1nt Mar 2, 2025

Choose a reason for hiding this comment

Uh oh!

TheAngryByrd Mar 2, 2025

Choose a reason for hiding this comment

Uh oh!

tw0po1nt Mar 2, 2025

Choose a reason for hiding this comment

Uh oh!

TheAngryByrd left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tw0po1nt commented Mar 1, 2025 •

edited

Loading