Skip to content

Suppress workspace only warnings if parent workspace has overlap #31473

@KyleJune

Description

@KyleJune

One usecase for having a workspace is so that you can override a package locally with a git submodule. When I do so, I get a bunch of warnings about the submodule/workspace having the unstable field in its configuration. For example, while working on a bug fix for deno-esbuild-plugin, I get warnings about the unstable field only being able to be specified in the root deno.json file. This warning is only really helpful if the workspaces root deno.json is missing the required field. Is this warning really needed if my root workspace has all the unstable APIs enabled that the submodule needs? For example, the root has unstable set to ["kv", "raw-imports"], and the child's deno.json has it set to ["raw-imports"]. I don't think a warning is needed in that case. But if the root unstable configuration was missing "raw-imports", then it would make sense to warn that it needs to be enabled in the root configuration.

Warning "unstable" field can only be specified in the workspace root deno.json file.
    at file:///home/kyle/Projects/udibo/juniper/libs/deno-esbuild-plugin/deno.json

Another use case where I encounter the same issue is when I have separate folders in my workspace for examples/templates. I want my templates to have the full deno.json configuration that users would have without it logging a bunch of warnings while I'm using it in the context of my workspace.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions