Skip to content

Conversation

@dsherret
Copy link
Member

@dsherret dsherret commented Dec 6, 2025

I don't think we should do this. This isn't what TypeScript does.

The fix in #31509 will move it to a typescript diagnostic instead of a hard error.

Reverts #31507

@coderabbitai
Copy link

coderabbitai bot commented Dec 6, 2025

Walkthrough

The changes remove a fallback resolution mechanism from the npm resolver logic. In libs/resolver/npm/mod.rs, the resolve_req_with_sub_path_inner function previously attempted a secondary resolution with NodeResolutionKind::Execution when encountering a TypeNotFound error. This fallback path is now removed, causing control flow to proceed to error handling directly. Additionally, all files associated with the nmd_manual_no_types test fixture are deleted, including the test configuration, Deno configuration, and test source file.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies this as a revert of PR #31507 that removed a fallback resolution attempt, which matches the actual changes removing code and test files from that prior fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly describes the changeset as a revert of a previous fix and explains the reasoning.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-31507-fix-manual-types-bug

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dsherret dsherret requested a review from nathanwhit December 6, 2025 00:23
@dsherret dsherret added this to the 2.6.0 milestone Dec 6, 2025
@dsherret dsherret enabled auto-merge (squash) December 6, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants