Skip to content

fix: make URLPatternComponentResult::groups values optional#35

Merged
crowlKats merged 6 commits into
mainfrom
162
Jul 26, 2024
Merged

fix: make URLPatternComponentResult::groups values optional#35
crowlKats merged 6 commits into
mainfrom
162

Conversation

@crowlKats
Copy link
Copy Markdown
Member

@crowlKats crowlKats marked this pull request as draft August 1, 2022 14:00
Comment thread src/regexp.rs
@crowlKats crowlKats marked this pull request as ready for review November 29, 2023 14:00
Copy link
Copy Markdown
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still failing...

@crowlKats crowlKats mentioned this pull request Nov 29, 2023
@crowlKats
Copy link
Copy Markdown
Member Author

crowlKats commented Nov 29, 2023

yes, there is quite a troublesome problem that needs to be figured out (different regexp matching behaviour between js (which is what the tests expect) and rust)

Copy link
Copy Markdown
Contributor

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 783c76b into main Jul 26, 2024
@crowlKats crowlKats deleted the 162 branch July 26, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants