Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 30, 2022

Node 18 will be LTS soon. Let's see what tests fail in the update.

@cjihrig
Copy link
Contributor Author

cjihrig commented Sep 1, 2022

The CI is hanging because of #2596. I worked around it locally. Here are the 29 failing tests on my machine (note that a few of these are resolved by #2584):

parallel/test-assert-async.js
parallel/test-assert-fail.js
parallel/test-dns-promises-exists.js
parallel/test-dns-resolvens-typeerror.js
parallel/test-events-once.js
parallel/test-eventtarget-brandcheck.js
parallel/test-fs-access.js
parallel/test-fs-append-file-sync.js
parallel/test-fs-copyfile.js
parallel/test-fs-rm.js
parallel/test-fs-write-file-sync.js
parallel/test-http-agent-getname.js
parallel/test-net-local-address-port.js
parallel/test-net-remote-address-port.js
parallel/test-readline-csi.js
parallel/test-stream-duplex-destroy.js
parallel/test-stream-duplex-from.js
parallel/test-stream-duplex.js
parallel/test-stream-readable-aborted.js
parallel/test-stream-readable-destroy.js
parallel/test-stream-readable-didRead.js
parallel/test-stream-readable-pause-and-resume.js
parallel/test-stream-readable-with-unimplemented-_read.js
parallel/test-stream-transform-destroy.js
parallel/test-stream-writable-destroy.js
parallel/test-stream-writable-end-cb-error.js
parallel/test-stream-writable-finish-destroyed.js
parallel/test-streams-highwatermark.js
parallel/test-webcrypto-sign-verify.js

UPDATE: This original list is changing as I push updates.

@cjihrig
Copy link
Contributor Author

cjihrig commented Sep 2, 2022

After some fixes and landing #2584, this is the list of current failures:

parallel/test-fs-rm.js --> Failing on Windows only. Compat layer needs to add execSync()

UPDATE: Pending and completed fixes:

parallel/test-assert-fail.js --> https://github.com/denoland/deno/pull/15789 (merged, in canary, will be in next release)
parallel/test-webcrypto-sign-verify.js --> Deno needs to support Ed25519 and Ed448 (https://github.com/denoland/deno/pull/14119)

cjihrig added a commit to denoland/deno that referenced this pull request Sep 7, 2022
This commit makes error objects more resistant to
prototype tampering.

This bug was found when updating the deno_std Node compatibility
layer to Node 18. The Node test 'parallel/test-assert-fail.js'
was breaking std's assertion library.

Refs: denoland/std#2585
@cjihrig cjihrig marked this pull request as ready for review September 7, 2022 21:54
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! LGTM

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, massive effort. Thank you @cjihrig!

@cjihrig cjihrig merged commit 9a19e98 into denoland:main Sep 8, 2022
@cjihrig cjihrig deleted the node18 branch September 8, 2022 13:23
kt3k pushed a commit to denoland/deno that referenced this pull request Sep 9, 2022
This commit makes error objects more resistant to
prototype tampering.

This bug was found when updating the deno_std Node compatibility
layer to Node 18. The Node test 'parallel/test-assert-fail.js'
was breaking std's assertion library.

Refs: denoland/std#2585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants