Local config: both read and write issue if user is not in the right dir#21
Merged
Richard-B18 merged 30 commits intomainfrom Jul 7, 2022
Merged
Local config: both read and write issue if user is not in the right dir#21Richard-B18 merged 30 commits intomainfrom
Richard-B18 merged 30 commits intomainfrom
Conversation
98sean98
reviewed
Jul 5, 2022
Richard-B18
commented
Jul 6, 2022
98sean98
requested changes
Jul 6, 2022
Contributor
98sean98
left a comment
98sean98
left a comment
There was a problem hiding this comment.
I think there are still some necessary changes.
98sean98
requested changes
Jul 7, 2022
Contributor
98sean98
left a comment
98sean98
left a comment
There was a problem hiding this comment.
Bug in code in line 149 of project/create.py with the raise abort.
98sean98
approved these changes
Jul 7, 2022
* support gcp for the feature, added some enums, minor bug fix * Project create command (#16) * enable create command * prompt workspace and query cloud profile in create command * calls backend graphql api to createProject * fix minor bugs of wrong api call, add some msg after api call * add a validation for project name * move cli msg to command callback instead of during api calling, minor bug fix * push everything * add is_authenticated decorator and refactor to use graphql fragments * bump package version to 0.1.2 * refractor auth checking, minor bug fix Co-authored-by: Sean Chok <seanchok@gmail.com> * gcp cloud profile creation, refractor auth checking * parse gcp key json file as string * rm unnecessary imports * Project Browse Command (#19) * Project Browse Command Adding project browse command to cli and get_workspace function to api * Changes Improved the browse and get project function * final refactor and test * bump package version to 0.1.3 Co-authored-by: Sean Chok <seanchok@gmail.com> * refractor cloud profile creation * change app structure for cloud profile creation * minor bug fix on passing variables for querying graphql * minor bug fix * minor issue Co-authored-by: Sean Chok <seanchok@gmail.com> Co-authored-by: ExtinctWolf83 <89630581+ExtinctWolf83@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.