Merged
Conversation
Closed
Changed the data init function to just initialize and added a new function data create to create new dataset
kschauhan3
force-pushed
the
dataset-create
branch
from
bf15438 to
8233902
Compare
98sean98
requested changes
Jul 11, 2022
Contributor
98sean98
left a comment
98sean98
left a comment
There was a problem hiding this comment.
Just a few minor changes.
98sean98
requested changes
Jul 11, 2022
Contributor
98sean98
left a comment
98sean98
left a comment
There was a problem hiding this comment.
Need a fix in the project_found decorator
deploifai/context.py
Outdated
| def wrapper(click_context, *args, **kwargs): | ||
| deploifai_context = click_context.find_object(DeploifaiContextObj) | ||
| if deploifai_context.local_config is not None: | ||
| if deploifai_context.local_config["PROJECT"]["id"] is not None: |
Contributor
There was a problem hiding this comment.
I think this might throw a KeyError when trying to access a key that doesn't exist in the dictionary. So maybe check using if 'id' in ...
98sean98
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.