Skip to content

Dataset init#38

Merged
kschauhan3 merged 14 commits intomainfrom
dataset-init
Jul 25, 2022
Merged

Dataset init#38
kschauhan3 merged 14 commits intomainfrom
dataset-init

Conversation

@kschauhan3
Copy link
Contributor

@kschauhan3 kschauhan3 commented Jul 20, 2022

Dataset init has been refactored
dataset_config.py file has been created
context.py file has been refactored to consider dataset.cfg file

@kschauhan3 kschauhan3 self-assigned this Jul 21, 2022
@kschauhan3 kschauhan3 added enhancement New feature or request summer 22 Summer 2022 project labels Jul 21, 2022
@kschauhan3 kschauhan3 linked an issue Jul 21, 2022 that may be closed by this pull request
dataset init command #37
Closed
98sean98
98sean98 requested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config file should also be recursively searched for, just like the local config file.

@kschauhan3 kschauhan3 marked this pull request as ready for review July 22, 2022 08:10
98sean98
98sean98 requested changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the dataset.cfg and write it to .gitignore

98sean98
98sean98 reviewed Jul 22, 2022
View reviewed changes
98sean98
98sean98 requested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small problem in dataset_config.

98sean98
98sean98 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kschauhan3 kschauhan3 merged commit cbb5464 into main Jul 25, 2022
@kschauhan3 kschauhan3 deleted the dataset-init branch July 25, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@98sean98 98sean98 98sean98 approved these changes

Assignees

@kschauhan3 kschauhan3

Labels

enhancement New feature or request summer 22 Summer 2022 project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dataset init command

2 participants

@kschauhan3 @98sean98