Skip to content

build dataset push and pull commands#47

Merged
98sean98 merged 27 commits intomainfrom
dataset-push
Aug 8, 2022
Merged

build dataset push and pull commands#47
98sean98 merged 27 commits intomainfrom
dataset-push

Conversation

@kschauhan3
Copy link
Contributor

No description provided.

@kschauhan3 kschauhan3 linked an issue Jul 28, 2022 that may be closed by this pull request
@kschauhan3 kschauhan3 added enhancement New feature or request summer 22 Summer 2022 project labels Jul 28, 2022
@kschauhan3 kschauhan3 self-assigned this Jul 28, 2022
@kschauhan3 kschauhan3 marked this pull request as ready for review July 29, 2022 03:01
@98sean98
Copy link
Contributor

98sean98 commented Aug 1, 2022

Should also add google-auth and google-cloud-storage as install_requires in setup.py

@kschauhan3
Copy link
Contributor Author

Should also add google-auth and google-cloud-storage as install_requires in setup.py

It has been added
Does not show up in file changes for some reason

Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small fix for the dataset_found decorator

):
return click_context.invoke(f, *args, **kwargs)

raise local_config.DeploifaiNotInitialisedError("dataset.cfg not found")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should tell the user how to initialize a dataset, and not just raise a dataset.cfg not found.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think of dataset.cfg not found, use deploifai dataset init to initialize a dataset ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, seems good, this message is printed in the terminal right?

@98sean98 98sean98 linked an issue Aug 4, 2022 that may be closed by this pull request
Copy link
Contributor

@98sean98 98sean98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes required

Comment on lines +26 to +27
click.secho("No dataset information extracted", fg="yellow")
click.secho("Please run deploifai dataset init again")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should just be Dataset has not been initialized, please run deploifai dataset init.

Copy link
Contributor Author

@kschauhan3 kschauhan3 Aug 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only happens if they have tampered with the dataset info
So unsure how to handle this

@98sean98 98sean98 changed the title Dataset push build dataset push and pull commands Aug 8, 2022
@98sean98 98sean98 merged commit 38818d9 into main Aug 8, 2022
@98sean98 98sean98 deleted the dataset-push branch August 8, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request summer 22 Summer 2022 project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dataset pull command dataset push command

2 participants