Open
Conversation
turboMaCk
commented
Aug 20, 2018
| }, | ||
|
|
||
| build: function(/* context */) { | ||
| var self = this; |
Author
There was a problem hiding this comment.
this variable was not used at all.
turboMaCk
commented
Aug 20, 2018
| }.bind(this)); | ||
| }, | ||
| _logSuccess: function(outputPath) { | ||
| var self = this; |
Author
There was a problem hiding this comment.
within this method, self was used over bind(this). I've changed functions to bind to unify code with other methods.
Contributor
|
Thank you!
I'm on holiday for 2 weeks but will review and merge after
If you have time, can you tell me how you found DeployJS, what you are
currently using it for against which deploy target?
Pepijn
…On Mon, 20 Aug 2018, 11:32 Marek Fajkus, ***@***.***> wrote:
Hello!
This is just a small chore as I've noticed few inconsistencies while
quickly scanning index.js. Nothing major.
------------------------------
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
- unify usage of context
File Changes
- *M* index.js
<https://github.com/deployjs/webpack-build/pull/2/files#diff-0> (8)
Patch Links:
- https://github.com/deployjs/webpack-build/pull/2.patch
- https://github.com/deployjs/webpack-build/pull/2.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAoow_dv-AKUAF39lGUmebLx6vANxsF3ks5uSoINgaJpZM4WDpkP>
.
|
Author
|
no worries. This is definitely nothing critical;) thx for this package. We're going to give it a try 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This is just a small chore as I've noticed few inconsistencies while quickly scanning index.js. Nothing major.