Skip to content

Allow multiple cachetool calls#3684

Merged
antonmedv merged 1 commit into
deployphp:masterfrom
infabo:patch-1
Sep 12, 2023
Merged

Allow multiple cachetool calls#3684
antonmedv merged 1 commit into
deployphp:masterfrom
infabo:patch-1

Conversation

@infabo
Copy link
Copy Markdown
Contributor

@infabo infabo commented Sep 11, 2023

  • Bug fix #…? No

  • New feature? Yes

  • BC breaks? I would say no. Possibly breaking for people that modified the recipe's tasks.

  • Tests added? No tests I am aware of. So none adjusted.

  • Docs added? Docs regenerated

    Please, regenerate docs by running next command:
    $ php bin/docgen
    

Copy link
Copy Markdown
Contributor

@Schrank Schrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great! Interesting idea :-)

Comment thread contrib/cachetool.php Outdated
Comment thread contrib/cachetool.php Outdated
Copy link
Copy Markdown
Contributor

@Schrank Schrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@antonmedv antonmedv merged commit 266554d into deployphp:master Sep 12, 2023
@infabo infabo deleted the patch-1 branch September 13, 2023 06:55
@yard-mschwartz
Copy link
Copy Markdown

It turns out we had a copy of the default opcache clear command in deploy.php, which broke the our deployment pipeline since v7.3.2, that includes this change. Only God knows why. 🙃

The error being: Array to string conversion in Configuration.php on line 136

Anyway, this is now solved by removing this copy, that shouldn't have been there in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants