Skip to content

Fix test function #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonmedv merged 1 commit into from
Oct 27, 2023
Merged

Fix test function #3717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ function runLocally(string $command, ?array $options = [], ?int $timeout = null,
function test(string $command): bool
{
$true = '+' . array_rand(array_flip(['accurate', 'appropriate', 'correct', 'legitimate', 'precise', 'right', 'true', 'yes', 'indeed']));
return run("if $command; then echo $true; fi") === $true;
return trim(run("if $command; then echo $true; fi")) === $true;
}

/**
Expand Down Expand Up @@ -558,8 +558,8 @@ function invoke(string $taskName): void
/**
* Upload files or directories to host.
*
* > To upload the _contents_ of a directory, include a trailing slash (eg `upload('build/', '{{release_path}}/public');`).
* > Without the trailing slash, the build directory itself will be uploaded (resulting in `{{release_path}}/public/build`).
* > To upload the _contents_ of a directory, include a trailing slash (eg `upload('build/', '{{release_path}}/public');`).
* > Without the trailing slash, the build directory itself will be uploaded (resulting in `{{release_path}}/public/build`).
*
* The `$config` array supports the following keys:
*
Expand All @@ -569,7 +569,7 @@ function invoke(string $taskName): void
* - `progress_bar` to display upload/download progress
* - `display_stats` to display rsync set of statistics
*
* Note: due to the way php escapes command line arguments, list-notation for the rsync `--exclude={'file','anotherfile'}` option will not work.
* Note: due to the way php escapes command line arguments, list-notation for the rsync `--exclude={'file','anotherfile'}` option will not work.
* A workaround is to add a separate `--exclude=file` argument for each exclude to `options` (also, _do not_ wrap the filename/filter in quotes).
* An alternative might be to write the excludes to a temporary file (one per line) and use `--exclude-from=temporary_file` argument instead.
*
Expand Down