Right clicking an empty area causes crash

[GeorgeHahn]

Reproduction:

• Open any directory and any view style
• Right click an empty area of the view

Additional details:
Windows 10 x64, build 10130

[GeorgeHahn]

After some investigation, I concluded that this is caused by the OneDrive filesyncshell.dll.

I was able to overcome it by turning on SEH exception handling in the Helper project and wrapping the QueryContextMenu call in the AddMenuEntries function of ContextMenuManager.cpp:

HRESULT hr;
try {
    hr = itr->pContextMenuActual->QueryContextMenu(
        hMenu, iStartPos, iMinID + iOffset, iMaxID,
        CMF_NORMAL | CMF_EXPLORE);
}
catch (...) {
    // Swallow context menu error
    continue;
}

[jtbrown3]

Verified that this critical crash behavior is still present in the official Windows 10 x64 release (build 10240).
Thx George for finding the workaroud. Would be great to get this committed into a fresh build. Otherwise it's a 'No-Go' for Win 10...

[macchky]

Temp fix is Launch as Administrator

[linquize]

Do Windows Explorer has such empty space to test with?

[derceg]

It would be good to find out exactly what's going wrong. It's quite possible there's a bug within the context menu code, particularly if the menu item appears correctly in other file managers (I haven't tested this myself, but I would assume it does - would anybody be able to confirm?).

It's interesting that it works when run as an administrator, I'm not sure why that would be the case, and obviously we don't have access to the OneDrive source code.

@GeorgeHahn
My concern with swallowing the exception is that it might result in an inconsistent state, which could lead to further crashes or corruption.

If anybody wants to debug through the code on Windows 10 and do some experimentation, that would be of great help. I'm happy to assist.

[juanitogan]

I ended up here because the new File Explorer in Win 10 is killing me. I get lost too easily scrolling the tree with its tiny indentations. And I work a lot in the tree. This right-click thing is almost a show stopper. For now I have Admin permanently set in the Compatibility tab for the file. I worry about the others frustrated with the new File Explorer and less savvy to figure out the workaround. Anyhow, thank you for what looks to be a quality solution to my File Explorer pains.

[derceg]

From some testing I've been doing, it looks like the OneDrive extension causes an access violation. It could be because of a bug in Explorer++, or a bug in OneDrive. Since the problem occurs inside the QueryContextMenu call, it would be difficult to figure out which is at fault.

I think the best way of handling this would be to blacklist the extension using its CLSID (which will at least stop the crashes). Then, if the issue is resolved in the future, the extension can be loaded again.

[real-felix]

Hello, the Explorer++ still crashes on Windows 8.x

When I right-click somewhere out of a file, it immediately crashes.

[endo64]

I confirm @Boiethios, Explorer++ still crashes on Win 8.1 x64.
Is this fix included in the latest compiled version on web site?