Fixed issue when CSV data wasn't properly escaped in HTML output#60
Merged
Conversation
added 8 commits
April 20, 2018 13:12
…king formatting just in time of rendering so original csvData variable is unchanged. To make it easier to determine template function corresponding to cell index we convert array of tuples into usual JS object (i.e. map/dictionary)
Author
|
Please review my PR: it's simple but contains a security fix |
Author
|
Hi @derekeder Could you please take a look on this patch? Thank you |
Owner
|
@stokito thanks for this & sorry for my delay in reviewing. PR approved & merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each cell in CSV can contain special characters like
<,>which can be considered by browser as a begging of HTML tag. This can broke layout and even can be used by a hacker for https://www.owasp.org/index.php/Cross-site_Scripting_(XSS)