-
Notifications
You must be signed in to change notification settings - Fork 0
Project 1 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Project 1 #1
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,93 @@ | ||
| import java.util.Scanner; | ||
|
|
||
|
|
||
| public class Main { | ||
| public static void main(String[] args) { | ||
| System.out.println("Hello world!"); | ||
| Scanner scanner = new Scanner(System.in); | ||
|
|
||
| final int RaceleMan = 24; | ||
| final int CarCount = 3; | ||
|
|
||
| Auto[] cars = new Auto[CarCount]; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. От хранения массива машин и лишнего цикла при определении победителя можно избавиться, если при вводе данных сразу вычислять победителя и хранить его в отдельной переменной, тогда программа будет требовать меньше памяти и работать быстрее |
||
|
|
||
| for (int i = 0; i < CarCount; i++) { | ||
| System.out.println("Введи название машины " + (i + 1) + ":"); | ||
| String name = scanner.nextLine().trim(); | ||
|
|
||
| int speed; | ||
| while (true) { | ||
| System.out.println("Введи скорость " + (i + 1) + " (целое число, >0 и ≤250):"); | ||
| String input = scanner.nextLine().trim(); | ||
| try { | ||
| speed = Integer.parseInt(input); | ||
| if (speed > 0 && speed <= 250) { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Минимальную и максимальную скорости лучше вынести в константы для повышения читабельности кода |
||
| break; | ||
| } else { | ||
| System.out.println("Некорректное значение. Пробуй снова."); | ||
| } | ||
| } catch (NumberFormatException e) { | ||
| System.out.println("Введи целое число."); | ||
| } | ||
| } | ||
|
|
||
| cars[i] = new Auto(name, speed); | ||
| } | ||
|
|
||
| Race race = new Race(cars); | ||
| Auto leader = race.madeLider(); | ||
|
|
||
| System.out.println("Самая быстрая машина: " + (leader != null ? leader.getName() : "не найден")); | ||
| scanner.close(); | ||
| } | ||
| } | ||
|
|
||
|
|
||
| class Auto { | ||
| private final String name; | ||
| private final int speed; | ||
|
Comment on lines
+46
to
+47
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Так как переменные помечены модификатором |
||
|
|
||
| public Auto(String name, int speed) { | ||
| this.name = name; | ||
| this.speed = speed; | ||
| } | ||
|
|
||
| public String getName() { | ||
| return name; | ||
| } | ||
|
|
||
| public int getSpeed() { | ||
| return speed; | ||
| } | ||
|
|
||
| public int distanceЗа24Часа() { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. В коде лучше не использовать кириллицу, так как это сильно затруднит чтение кода. Код пишется обычно только на одном языке. На русском можно написать комментарий или документацию к методу |
||
| return speed * 24; | ||
| } | ||
| } | ||
|
|
||
|
|
||
| class Race { | ||
| private final Auto[] cars; | ||
| private final Auto leader; | ||
|
|
||
| public Race(Auto[] cars) { | ||
| this.cars = cars; | ||
| this.leader = determineLeader(); | ||
| } | ||
|
|
||
| private Auto determineLeader() { | ||
| Auto maxCar = null; | ||
| int maxDistance = -1; | ||
| for (Auto car : cars) { | ||
| int dist = car.distanceЗа24Часа(); | ||
| if (dist > maxDistance) { | ||
| maxDistance = dist; | ||
| maxCar = car; | ||
| } | ||
| } | ||
| return maxCar; | ||
| } | ||
|
|
||
| public Auto madeLider() { | ||
| return leader; | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Эти две переменные можно положить в константы на уровне класса, чтобы не объявлять их внутри метода, там же их можно назвать в соответствии с SCREAMING_SNAKE_CASE как настоящие константы)