Skip to content

Remove Sync Peer Disconnect When Header Tip Is Not Current After Syncing Headers #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tholonious merged 1 commit into from
Apr 23, 2024
Merged

Remove Sync Peer Disconnect When Header Tip Is Not Current After Syncing Headers #1264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions lib/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1117,19 +1117,6 @@ func (srv *Server) _handleHeaderBundle(pp *Peer, msg *MsgDeSoHeaderBundle) {
maxHeadersPerMsg = MaxHeadersPerMsgPos
}
if uint32(len(msg.Headers)) < maxHeadersPerMsg || srv.blockchain.isTipMaxed(srv.blockchain.headerTip()) {
// If we have exhausted the peer's headers but our header chain still isn't
// current it means the peer we chose isn't current either. So disconnect
// from her and try to sync with someone else.
if srv.blockchain.chainState() == SyncStateSyncingHeaders {
glog.V(1).Infof("Server._handleHeaderBundle: Disconnecting from peer %v because "+
"we have exhausted their headers but our tip is still only "+
"at time=%v height=%d", pp,
time.Unix(int64(srv.blockchain.headerTip().Header.GetTstampSecs()), 0),
srv.blockchain.headerTip().Header.Height)
pp.Disconnect()
return
}

// If we get here it means that we've just finished syncing headers and we will proceed to
// syncing state either through hyper sync or block sync. First let's check if the peer
// supports hypersync and if our block tip is old enough so that it makes sense to sync state.
Expand Down