Skip to content

Conditionally queue block bundles in expected responses and dequeue them in _handleInExpectedResponse. don't queue msg in _cleanupDonePeerState if there are no transactions. also exit early if peer can't accept inv messages #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lazynina merged 1 commit into from
Jul 8, 2024
Merged

Conditionally queue block bundles in expected responses and dequeue them in _handleInExpectedResponse. don't queue msg in _cleanupDonePeerState if there are no transactions. also exit early if peer can't accept inv messages #1384

lazynina merged 1 commit into from
Jul 8, 2024

Conversation

@lazynina
Copy link
Member

@lazynina lazynina commented Jul 8, 2024

don't queue msg in _cleanupDonePeerState if there are no transactions. also exit early if peer can't accept inv messages

@lazynina lazynina requested a review from a team as a code owner July 8, 2024 05:30
@lazynina Graphite App
Copy link
Member Author

lazynina commented Jul 8, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lazynina and the rest of your teammates on Graphite Graphite

@lazynina lazynina mentioned this pull request Jul 8, 2024
Merged
diamondhands0
diamondhands0 approved these changes Jul 8, 2024
View reviewed changes
@lazynina lazynina force-pushed the fix-expected-responses branch from e85606c to 7edc5cc Compare July 8, 2024 05:34
@lazynina Graphite App
Copy link
Member Author

lazynina commented Jul 8, 2024 •
edited
Loading

Merge activity

  • Jul 8, 1:57 AM EDT: @lazynina started a stack merge that includes this pull request via Graphite.
  • Jul 8, 1:58 AM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 8, 1:59 AM EDT: @lazynina merged this pull request with Graphite.

Base automatically changed from fix-hypersync-start-condition-after-pos-setup to main July 8, 2024 05:57
@lazynina
Conditionally queue block bundles in expected responses and dequeue t…
f7fad80 
…hem in _handleInExpectedResponse.

don't queue msg in _cleanupDonePeerState if there are no transactions. also exit early if peer can't accept inv messages
@lazynina lazynina force-pushed the fix-expected-responses branch from 7edc5cc to f7fad80 Compare July 8, 2024 05:58
@lazynina lazynina merged commit eca6673 into main Jul 8, 2024
@lazynina lazynina deleted the fix-expected-responses branch July 8, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diamondhands0 diamondhands0 diamondhands0 approved these changes

+1 more reviewer

@tholonious tholonious tholonious approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lazynina @diamondhands0 @tholonious