If less than 50% of congestion threshold, return min fee rate #1393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
diamondhands0
approved these changes
Aug 1, 2024
| // If there are no txns in the transaction register, we simply return the minimum network fee. | ||
| // Compute the congestion threshold. If our congestion factor is 100% (or 10,000 bps), | ||
| // then congestion threshold is simply max block size * numPastBlocks | ||
| congestionThreshold := (congestionFactorBasisPoints * maxSizeOfNumBlocks) / MaxBasisPoints |
Member
There was a problem hiding this comment.
Do we need to check overflow? I think it's fine because they'll never break the uint64 right?
Member
Author
There was a problem hiding this comment.
it'll never overflow - it's safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.