if snapshot initialization error is a checksum issue, ignore if force… #1406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… checksum is set to false
diamondhands0
approved these changes
Sep 16, 2024
Member
diamondhands0
left a comment
diamondhands0
left a comment
There was a problem hiding this comment.
I think I found a little bug, otherwise looks good to me.
lib/snapshot.go
Outdated
| // remove, (3) ProcessChunk, (4) ChecksumPrint, (5) Exit. So the only one operation that isn't checksum related | ||
| // is the ProcessChunk operation. However, I think we can get away with this being considered a "checksum" issue | ||
| // and not restarting the node (which causes a panic). If you have a node that didn't finish processing chunks, | ||
| // just start over again. |
Member
There was a problem hiding this comment.
I would add just for extra clarity:
However, I think we can get away with this being considered a "checksum" issue because ProcessChunk only happens during initial sync
lib/snapshot.go
Outdated
| if err := migrations.StartMigrations(); err != nil { | ||
| // @diamondhands - If we hit this error, it means that the migration failed. Should we | ||
| // consider this a "checksum" issue or not? I believe the migrations are only necessary | ||
| // for checksums, but I'm unsure. |
Member
There was a problem hiding this comment.
Yep, migrations are only needed to guarantee that checksums match. They don't change anything about how the data the node is processing is handled. I'd add that to the comment and run with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… checksum is set to false