Merge feature/pos-txn-types into feature/proof-of-stake #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* POS fixes and comments from diamondhands * Mf/pos txn types review (#531) * Add comments. * Addres review comments. * Add first batch of sanity check utils. * Add second batch of txn sanity checks. * Rename encode uint256 funcs in comments. * Nuke RegisteredAtBlockHeight. * Address review feedback. * Fix a few more typos. * Update some comments --------- Co-authored-by: diamondhands <diamondhands@bitcloutdev.com> --------- Co-authored-by: Matt Foley <100429827+mattfoley8@users.noreply.github.com>
mattfoley8
changed the title
lazynina
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POS fixes and comments from diamondhands
Mf/pos txn types review (Mf/pos txn types review #531)
Add comments.
Addres review comments.
Add first batch of sanity check utils.
Add second batch of txn sanity checks.
Rename encode uint256 funcs in comments.
Nuke RegisteredAtBlockHeight.
Address review feedback.
Fix a few more typos.
Update some comments