Add BLS Signature Verification for Multiple Payloads #575
+90
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
tholonious
commented
Jul 5, 2023
| // This is the only supported BLS signing algorithm in the flowCrypto package. | ||
| // BLS is used such that we can aggregate signatures into one signature. | ||
| const SigningAlgorithm = flowCrypto.BLSBLS12381 | ||
| const signingAlgorithm = flowCrypto.BLSBLS12381 |
Contributor
Author
There was a problem hiding this comment.
This signingAlgorithm const and hashingAlgorithm global variable are implementation details of how this package wraps the flow BLS scheme implementation underneath.
We don't want this package to expose them externally, so it's best to make them private.
tholonious
changed the title
lazynina
reviewed
Jul 5, 2023
lazynina
approved these changes
Jul 5, 2023
tholonious
deleted the
sa/add-bls-signature-verification-for-multiple-payloads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.