Add block proposer public keys and signature to block header #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
tholonious
commented
Jul 5, 2023
lazynina
requested changes
Jul 5, 2023
lazynina
approved these changes
Jul 5, 2023
AeonSw4n
suggested changes
Jul 5, 2023
Contributor
AeonSw4n
left a comment
AeonSw4n
left a comment
There was a problem hiding this comment.
Looks good! Got one comment regarding the handling of preSignature flag. In addition, I think we should increase our test coverage around MsgDeSoHeader, in particular testing the signing of the header hash.
| // The preSignature flag is unused during byte encoding in | ||
| // in header versions 0 and 1. We set it to true to ensure that | ||
| // it's forward compatible for versions 2 and beyond. | ||
| headerBytes, err := msg.ToBytes(true) |
Contributor
There was a problem hiding this comment.
Ah yes so my initial comment re preSignature flag is applicable. We should add tests for signing the Hash to make sure everything is bulletproof.
Contributor
Author
AeonSw4n
approved these changes
Jul 6, 2023
tholonious
deleted the
sa/add-block-propser-keys-and-signature-to-block-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.