Filter validator jailing to just the current validator set #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 18, 2023
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
tholonious
commented
Jul 18, 2023
| } | ||
|
|
||
| func (bav *UtxoView) ShouldJailValidator(validatorEntry *ValidatorEntry, blockHeight uint64) (bool, error) { | ||
| // Return false if we haven't switched from PoW to PoS yet. Otherwise, |
Contributor
Author
There was a problem hiding this comment.
This condition does not belong here. The caller should determine ahead of time if the block height is past the PoS consensus cutover.
The role of this function should be simple: given a validator, determine if that validator is inactive based on the attributes of that validator.
lazynina
approved these changes
Jul 18, 2023
Base automatically changed from
Revert_UtxoOp_Emits_in_Stake_Reward_Distribtion
to
feature/pos-staker-snapshotting-and-rewards
July 18, 2023 17:51
tholonious
force-pushed
the
Filter_validator_jailing_to_just_the_current_validator_set
branch
from
401091b to
6f10bf0
Compare
tholonious
deleted the
Filter_validator_jailing_to_just_the_current_validator_set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.