Implement Staking Rewards APY Computations #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2023
Contributor
Author
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
tholonious
changed the title
tholonious
force-pushed
the
Add_Global_Param_for_Staking_Rewards_Interest_Rate
branch
from
56039cf to
d97bde5
Compare
tholonious
changed the title
tholonious
force-pushed
the
Add_Global_Param_for_Staking_Rewards_Interest_Rate
branch
from
d97bde5 to
8c8d69c
Compare
Base automatically changed from
Add_Global_Param_for_Staking_Rewards_Interest_Rate
to
feature/pos-staker-snapshotting-and-rewards
July 25, 2023 17:24
tholonious
changed the base branch from
feature/pos-staker-snapshotting-and-rewards
to
Refactor_end_of_epoch_unit_test
tholonious
force-pushed
the
Implement_Interest_Rate_Computations_For_Staking_Rewards
branch
from
39b30b3 to
ed4fde5
Compare
Base automatically changed from
Refactor_end_of_epoch_unit_test
to
feature/pos-staker-snapshotting-and-rewards
July 26, 2023 15:02
tholonious
force-pushed
the
Implement_Interest_Rate_Computations_For_Staking_Rewards
branch
from
ed4fde5 to
dbeac31
Compare
tholonious
changed the base branch from
feature/pos-staker-snapshotting-and-rewards
to
Deprecate_old_placeholder_staking_reward_distribution_logic
tholonious
force-pushed
the
Implement_Interest_Rate_Computations_For_Staking_Rewards
branch
from
dbeac31 to
aecb5a0
Compare
Base automatically changed from
Deprecate_old_placeholder_staking_reward_distribution_logic
to
feature/pos-staker-snapshotting-and-rewards
July 26, 2023 18:17
tholonious
force-pushed
the
Implement_Interest_Rate_Computations_For_Staking_Rewards
branch
from
b3cba0d to
d4a7164
Compare
lazynina
reviewed
Jul 26, 2023
| // staking reward. This is fine though, because if the validator wants to restake their own rewards but not their commissions, then | ||
| // they can stake to themselves using a separate wallet and only enable reward restaking for that StakeEntry. | ||
| // | ||
| // If the above isn't desired the behavior, then we can alternatively always pay out validator's commission directly to their wallet. |
Member
There was a problem hiding this comment.
one of the other long term benefits of how this code is set up is that we can track how much a validator got from commissions from a specific staker (if we simply pass in the staker's PKID when we call this function) when we do some utxo operation refactoring work.
lazynina
approved these changes
Jul 26, 2023
tholonious
force-pushed
the
Implement_Interest_Rate_Computations_For_Staking_Rewards
branch
2 times, most recently
from
33f4ab5 to
dd83c63
Compare
tholonious
force-pushed
the
Implement_Interest_Rate_Computations_For_Staking_Rewards
branch
from
dd83c63 to
683c3e0
Compare
tholonious
force-pushed
the
Implement_Interest_Rate_Computations_For_Staking_Rewards
branch
from
38ad0f0 to
fe1c15e
Compare
AeonSw4n
approved these changes
Jul 31, 2023
tholonious
deleted the
Implement_Interest_Rate_Computations_For_Staking_Rewards
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.