Z/hypersync db settings fix #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazynina
approved these changes
Jan 10, 2024
| performanceOptions, err := lib.DbInitializedWithPerformanceOptions(node.Config.DataDirectory) | ||
|
|
||
| // If the db options haven't yet been saved, we should base the options on the sync type. | ||
| if os.IsNotExist(err) { |
Member
There was a problem hiding this comment.
Whenever we encounter an annoying bug like this I basically like to leave the post-mortem in a long comment next to the change. Here, I would explain that the reason why you need to save the options to disk is because Badger breaks if you (a) shutdown (b) without closing (c) and then re-open with different options.
The other reason why this is good is it gives us the confidence to delete hacks like this in the future, rather than being scared that we'll break something if we do.
Co-authored-by: Lazy Nina <81658138+lazynina@users.noreply.github.com>
…-protocol/core into z/hypersync-db-settings-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix badger db options for node restarts when hypersyncing.