Add cached entries entity to reduce number of inserts from db #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazynina
reviewed
Oct 14, 2024
Member
lazynina
left a comment
lazynina
left a comment
There was a problem hiding this comment.
I would probably swap out the map you're using for the cache w/ an LRU cache from hashicorp so you don't need to manually clear it out. this way we can just jam whatever we want in there and get the performance enhancements. can tune to increase the size off the lru cache (at the detriment of memory) or decrease the size (at the detriment of the speed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.