Skip to content

Fix issue #15, add attribute to avoid a warning by GCC#16

Merged
devanlai merged 1 commit intodevanlai:masterfrom
0x3333:issue15
Aug 9, 2019
Merged

Fix issue #15, add attribute to avoid a warning by GCC#16
devanlai merged 1 commit intodevanlai:masterfrom
0x3333:issue15

Conversation

@0x3333
Copy link
Copy Markdown
Contributor

@0x3333 0x3333 commented Aug 9, 2019

As mentioned in the issue #15, added an attribute to avoid GCC issue a warning regarding a fall through.

@devanlai
Copy link
Copy Markdown
Owner

devanlai commented Aug 9, 2019

Hrm, I thought the existing /* Fall through */ would be sufficient, but apparently gcc is very picky about the location of the fall-through comment.

Unfortunately, adding the __attribute__ ((fallthrough)) generates a warning: empty declaration. However, it still compiles and all else equal, I'm fine with having warnings on ancient compiler versions if it makes the latest compiler version warning-free.

@devanlai devanlai merged commit 0071344 into devanlai:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants