Allow more flexibility when configuring from config.h#38
Merged
devanlai merged 1 commit intodevanlai:masterfrom Sep 4, 2021
Merged
Allow more flexibility when configuring from config.h#38devanlai merged 1 commit intodevanlai:masterfrom
devanlai merged 1 commit intodevanlai:masterfrom
Conversation
In order to be able to override the VID and PID for a device from inside its config.h, config.h needs to be included before usb_conf.h
Owner
|
This seems pretty reasonable to me and it builds cleanly. |
twelho
added a commit
to twelho/dapboot
that referenced
this pull request
Sep 10, 2021
…o to USB_DFU_ALTN Assesses review feedback. I could initially not get the macros to work in usb_conf.c, but they seem to work now even though the changes from pull devanlai#38 have been present in the development tree from the start.
twelho
added a commit
to twelho/dapboot
that referenced
this pull request
Sep 10, 2021
…o to USB_DFU_ALTN Assesses review feedback. I could initially not get the macros to work in usb_conf.c, but they seem to work now even though the changes from pull devanlai#38 have been present in the development tree from the start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to be able to override the VID and PID for a device from inside
its config.h, config.h needs to be included before usb_conf.h
This lets you stick something like this in config.h and have it 'just work'