Skip to content

added .ipynb support#58

Merged
devblackops merged 4 commits intodevblackops:mainfrom
gaardhus:main
Dec 16, 2021
Merged

added .ipynb support#58
devblackops merged 4 commits intodevblackops:mainfrom
gaardhus:main

Conversation

@gaardhus
Copy link
Contributor

@gaardhus gaardhus commented Nov 23, 2021

Description

Added custom icon and color for .ipynb files

Related Issue

#57

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaardhus
Copy link
Contributor Author

Alternatively this is the glyph used in VS Code  (which also uses same color for .py and .ipynb files), I've tried adding it to the glyhps.ps1 file, but it does not render in PowerShell.

image

@gaardhus
Copy link
Contributor Author

After digging around I found the right glyph, it just rendered in a weird way initially. I chaged the glyph and color in the last commit to reflect this, and the other implementations in this package.

image

However, I guess it can still be discussed if .ipynb files should have the same color as .py files, since they can also be used for other languages.

@devblackops
Copy link
Owner

What about orange (#E46E2E) for the color? That's what the theme seems to be on jupyter.org.

@devblackops devblackops merged commit d634292 into devblackops:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants