Skip to content

[Desktop-lite] - VNC_RESOLUTION unreadable fix - issue #945 fix#1024

Merged
samruddhikhandale merged 15 commits intodevcontainers:mainfrom
gauravsaini04:deskto-lite_vnc_resolution_fix
Aug 6, 2024
Merged

[Desktop-lite] - VNC_RESOLUTION unreadable fix - issue #945 fix#1024
samruddhikhandale merged 15 commits intodevcontainers:mainfrom
gauravsaini04:deskto-lite_vnc_resolution_fix

Conversation

@gauravsaini04
Copy link
Copy Markdown
Contributor

@gauravsaini04 gauravsaini04 commented Jun 28, 2024

Feature name:

  • Desktop-lite

Description:

This PR introduces the following functionality :

Changelog:

  • Updated install.sh
  • Added a single quotes wrapper around EOF so as to disable variable expansion during build time, and such that the variable's values can be read when they are needed i.e. during runtime of container.

Checklist:

  • Checked that applied changes work as expected

@gauravsaini04 gauravsaini04 requested a review from a team as a code owner June 28, 2024 17:34
@gauravsaini04 gauravsaini04 mentioned this pull request Jun 28, 2024
Closed
@samruddhikhandale samruddhikhandale linked an issue Jun 28, 2024 that may be closed by this pull request
[desktop-lite] Entrypoint script does not use VNC_RESOLUTION defined by containerEnv #945
Closed
samruddhikhandale
samruddhikhandale requested changes Jun 28, 2024
View reviewed changes
Comment thread src/desktop-lite/install.sh
Comment thread src/desktop-lite/install.sh
samruddhikhandale
samruddhikhandale approved these changes Jun 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ⚡

@samruddhikhandale
Copy link
Copy Markdown
Member

samruddhikhandale commented Jul 1, 2024

@gauravsaini04 Can you look into test failures?

@gauravsaini04
Copy link
Copy Markdown
Contributor Author

gauravsaini04 commented Jul 8, 2024

@gauravsaini04 Can you look into test failures?

Hi @samruddhikhandale ,
have tested locally with a couple of these scenarios and they seem to be passing the log-exists test there in the codespace

samruddhikhandale
samruddhikhandale requested changes Jul 8, 2024
View reviewed changes
Comment thread src/desktop-lite/install.sh
samruddhikhandale
samruddhikhandale requested changes Aug 1, 2024
View reviewed changes
Comment thread src/desktop-lite/install.sh
samruddhikhandale
samruddhikhandale approved these changes Aug 6, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@samruddhikhandale samruddhikhandale merged commit f5f489f into devcontainers:main Aug 6, 2024
@gauravsaini04 gauravsaini04 deleted the deskto-lite_vnc_resolution_fix branch August 6, 2024 22:34
@NicholasWalton NicholasWalton mentioned this pull request Aug 12, 2024
Closed
samruddhikhandale added a commit that referenced this pull request Aug 13, 2024
@samruddhikhandale
Revert "[Desktop-lite] - VNC_RESOLUTION unreadable fix - issue #945 f…
d2bd3ee 
…ix (#1024)"

This reverts commit f5f489f.
samruddhikhandale added a commit that referenced this pull request Aug 13, 2024
@samruddhikhandale
Revert "[Desktop-lite] - VNC_RESOLUTION unreadable fix - issue #945 f…
9b18903 
…ix (#1024) (#1088)

Revert "[Desktop-lite] - VNC_RESOLUTION unreadable fix - issue #945 fix (#1024)"

This reverts commit f5f489f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[desktop-lite] Entrypoint script does not use VNC_RESOLUTION defined by containerEnv

2 participants

@gauravsaini04 @samruddhikhandale